Fix GH-9420: Avoid invalid use of internal attributes on promoted properties #9661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me ! Thanks |
adoy
approved these changes
Oct 27, 2022
saundefined
approved these changes
Oct 27, 2022
|
This change makes sense to me. Userland attributes don't have this issue because they're read (thus checked) on demand. An alternate approach might be to read internal attributes on demand also, but this might be more involving. This would allow using eg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal attributes may cause compilation errors when used on promoted properties. This was reported in #9420. This PR fixes the reported bug by dropping unsupported internal attributes during compilation of promoted properties. This works for attributes that apply to a parameter but not a property (has been reported as bug). It also fixes the situation where an attribute applies to a property but not a parameter (not yet reported as bug).
Userland attributes are not affected by this change and unfortunately (due to the way they are implemented) cannot be fixed in the same way.