Skip to content

Reduce scope of r in rand_rangeXX #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Oct 5, 2022

This variable is only accessed within a single iteration of the expansion loop.


Found while looking into implementing a getFloat().

This variable is only accessed within a single iteration of the expansion loop.
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It's nice to have the very short variable name constrained to a small scope.

@TimWolla TimWolla merged commit 59a19d7 into php:PHP-8.2 Oct 6, 2022
@TimWolla TimWolla deleted the rand-range-scope branch October 6, 2022 10:56
TimWolla added a commit that referenced this pull request Oct 6, 2022
* PHP-8.2:
  Reduce scope of `r` in rand_rangeXX (#9678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants