Skip to content

RFC: Add #[Override] attribute #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2023
Merged

RFC: Add #[Override] attribute #9836

merged 5 commits into from
Jun 29, 2023

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Oct 26, 2022 •
edited
Loading

@iluuu1994 iluuu1994 added the RFC label Oct 26, 2022
@thekid thekid mentioned this pull request Nov 23, 2022
Closed
4 tasks
@TimWolla TimWolla force-pushed the override-attribute branch 2 times, most recently from a4606e7 to 9196c03 Compare April 27, 2023 17:33
iluuu1994
iluuu1994 reviewed Apr 27, 2023
View reviewed changes
@TimWolla TimWolla changed the title Add #[Override] attribute RFC: Add #[Override] attribute May 11, 2023
@TimWolla TimWolla force-pushed the override-attribute branch from 4c9d9d0 to d48a195 Compare June 26, 2023 15:02
@TimWolla TimWolla marked this pull request as ready for review June 28, 2023 08:33
@TimWolla TimWolla requested a review from dstogov as a code owner June 28, 2023 08:33
@TimWolla
Copy link
Member Author

The RFC is accepted and the failing tests appear to be unrelated.

@TimWolla TimWolla requested a review from iluuu1994 June 28, 2023 08:33
iluuu1994
iluuu1994 reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me, thanks @TimWolla!

@TimWolla TimWolla requested a review from iluuu1994 June 29, 2023 18:17
@TimWolla
Copy link
Member Author

Okay, I believe I made all the requested changes (and hopefully correctly). Please double-check it. If it's good I'll add NEWS / UPGRADING notes myself and merge.

iluuu1994
iluuu1994 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks fine, thanks!

@TimWolla TimWolla merged commit 49ef6e2 into php:master Jun 29, 2023
@TimWolla TimWolla deleted the override-attribute branch June 29, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @iluuu1994