Skip to content

Migrate i386 to GitHub actions #9856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 force-pushed the github-actions-i386 branch from dc788d5 to 8e35f7f Compare October 30, 2022 21:49
@iluuu1994
Copy link
Member Author

This executes ~100 tests less, most because it runs as root. Running the container with a different user doesn't seem possible on GitHub actions (https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user) (unless I'm misinterpreting this statement).

@iluuu1994 iluuu1994 closed this in 7597007 Nov 3, 2022
Comment on lines +6 to +10
--SKIPIF--
<?php
if (!extension_loaded('posix')) die('skip POSIX extension not loaded');
if (posix_geteuid() == 0) die('skip Cannot run test as root.');
?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skips the test on Windows, although it otherwise would work fine. On Windows, there is no need to check the euid at all, which could easily be fixed. However, the follow-up fix (d2c6634) which is fine per se, makes it more difficult to also run the test on Windows (due to having posix in the --EXTENSION-- section). Maybe we should split this test. Or, if we expect more such posix_geteuid() == 0 (should probably better be posix_geteuid() === 0) checks, then it may make sense to come up with a more general solution (possibly a new marker section which does this check and the skipping behind the scenes). @iluuu1994, thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about Windows. TBH I didn't look into why exactly the test was failing with root, but for this test it's probably fine to remove posix from EXTENSIONS and skip the root check for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants