Fix GH-9883 SplFileObject::__toString() reads next line #9912
Conversation
|
I'm not sure if it makes any sense to target PHP-8.0; there may be no further regular bug fix release. But even if, it might be too risky that late in the release cycle (especially given that the bug is there for years). |
Should I change the branch to 8.1 then? or also leave 8.1 alone and only target 8.2? |
Depends on how certain we can be that this doesn't break existing code. I tend to think that it's good for 8.1. |
We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it Moreover, the custom cast handler is useless as we define __toString methods, so use the standard one instead.
| <?php | ||
| $file_stream = new SplFileObject(__FILE__, 'rb'); | ||
|
|
||
| echo $file_stream; // line 4 |
There was a problem hiding this comment.
Why such comments? I would remove them.
There was a problem hiding this comment.
See #9883. The comments helped to identify what was going on, and may be helpful if something breaks (again) in the future.
We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it Moreover, the custom cast handler is useless as we define __toString methods, so use the standard one instead.