Fix run-tests.php hanging when a worker process dies without notice #9931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures appear to be unrelated |
run-tests.php with `-jN` can hang if a parallel worker dies without notice. This
can happen due to fatal errors in the worker, or if the worker is killed.
- run-tests.php (main process)
\_ run-tests.php (worker #0) // main process hangs if this one crashes
\_ test-001.php (test-001.phpt)
2b609e5 to
16e21b2
Compare
iluuu1994
approved these changes
Jan 13, 2023
arnaud-lb
added a commit
that referenced
this pull request
Jan 13, 2023
* PHP-8.1: Fix run-tests.php hanging when a worker process dies without notice (#9931)
arnaud-lb
added a commit
that referenced
this pull request
Jan 13, 2023
* PHP-8.2: Fix run-tests.php hanging when a worker process dies without notice (#9931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run-tests.php with
-jNcan hang if a parallel worker dies without notice. This can happen due to fatal errors in the worker, or if the worker is killed.