Skip to content

Fix the replacement for shmget in Windows #9946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix the replacement for shmget in Windows #9946

wants to merge 3 commits into from

Conversation

TysonAndre
Copy link
Contributor

Closes #9944

https://man7.org/linux/man-pages/man2/shmget.2.html notes

The name choice IPC_PRIVATE was perhaps unfortunate, IPC_NEW
would more clearly show its function.

@TysonAndre TysonAndre requested a review from cmb69 November 13, 2022 21:21
@TysonAndre TysonAndre force-pushed the fix-9944-windows-shm_get branch 2 times, most recently from 0ea9e26 to 176c011 Compare November 13, 2022 21:51
@TysonAndre
Fix the replacement for shmget in Windows
8db6bd5 
Closes php#9944

https://man7.org/linux/man-pages/man2/shmget.2.html notes

   The name choice IPC_PRIVATE was perhaps unfortunate, IPC_NEW
   would more clearly show its function.
@TysonAndre TysonAndre force-pushed the fix-9944-windows-shm_get branch from 176c011 to 8db6bd5 Compare November 13, 2022 22:00
TysonAndre
TysonAndre commented Nov 13, 2022
View reviewed changes
cmb69
cmb69 reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! The general solution looks good to me, but we likely need to figure out some details.

@cmb69 cmb69 linked an issue Nov 15, 2022 that may be closed by this pull request
Windows C shmget(IPC_PRIVATE, ...) returns IPC_PRIVATE(0) instead of distinct id for new section #9944
Closed
cmb69
cmb69 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't see a reasonable way to add a test case (adding something to ext/zend_test appears to be overkill), so this looks good to me.

@cmb69 cmb69 closed this in 7a983e2 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows C shmget(IPC_PRIVATE, ...) returns IPC_PRIVATE(0) instead of distinct id for new section
2 participants
@TysonAndre @cmb69