chore: package bumps #1232
chore: package bumps #1232
Conversation
🦋 Changeset detectedLatest commit: 0998824 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
WalkthroughDependency version bumps across multiple package.json files: upgraded runtime Effect packages (effect, @effect/*), dev/test tooling (tsdown, @effect/vitest), and @effect/language-service in tooling. No source code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
📦 Bundle size comparison
|
More templates
@uploadthing/expo
@uploadthing/mime-types
@uploadthing/nuxt
@uploadthing/react
@uploadthing/shared
uploadthing
@uploadthing/vue
commit: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tooling/tsconfig/package.json (1)
9-11: Tooling bumps LGTM; consider dependency classification.
- Upgrading @effect/language-service and effect is fine. Optional: you could keep these as devDependencies (or peerDependencies + devDependencies) if this package is only consumed in-repo for tooling, to avoid hoisting them as regular deps when published.
If you want to explore that direction, I can propose a variant with peerDependencies/devDependencies and a small README note about expected workspace tooling versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
examples/backend-adapters/server/package.json(1 hunks)packages/expo/package.json(1 hunks)packages/mime-types/package.json(1 hunks)packages/react/package.json(1 hunks)packages/shared/package.json(2 hunks)packages/uploadthing/package.json(2 hunks)packages/vue/package.json(1 hunks)playground-v6/package.json(1 hunks)playground/package.json(1 hunks)tooling/tsconfig/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: bundle-analyze-result
- GitHub Check: build
- GitHub Check: typecheck
- GitHub Check: lint
- GitHub Check: build
- GitHub Check: e2e-node (minimal-pagedir)
- GitHub Check: e2e-node (minimal-appdir)
- GitHub Check: e2e-node (backend-adapters)
- GitHub Check: build
🔇 Additional comments (13)
packages/mime-types/package.json (1)
93-93: tsdown version and Node/TypeScript compatibility verified
- All workspace packages (packages/expo, packages/mime-types, packages/react, packages/shared, packages/vue, packages/uploadthing) use [email protected].
- Root package.json’s
"node": ">=22.x"meets [email protected]’s"node": ">=20.19.0"requirement.- Dev TypeScript is 5.8.3 everywhere, satisfying tsdown’s
typescript: "^5.0.0"peer requirement.playground/package.json (1)
14-14: effect version alignment complete
All packages depending oneffectare now pinned to 3.17.7, so there are no mismatched versions in the workspace and no risk of multiple copies or subtle type inconsistencies. No further dependency updates are needed here.(Optional) Review the Effect 3.17.x release notes for any breaking changes that might impact our usage.
packages/react/package.json (1)
91-91: tsdown 0.14.1 bump LGTM; ensure CI build stays green.
- Matches pattern used elsewhere (build/dev scripts). No further changes needed.
Optionally confirm uniform tsdown usage and Node/TS versions with the script I shared on the mime-types package comment.
packages/expo/package.json (1)
49-49: tsdown 0.14.1 bump LGTM.
- Consistent with other packages. Expo’s React/React Native setup is unchanged; no conflicts anticipated from this dev tooling update.
packages/vue/package.json (1)
49-49: tsdown bump LGTM; repo‐wide version consistency confirmed
- All packages that declare tsdown in devDependencies (expo, mime-types, react, shared, vue, uploadthing) are pinned to 0.14.1.
- No package invokes tsdown in its scripts without declaring it as a devDependency.
Please verify that the
--no-cleanflag is still supported in [email protected] before merging.packages/shared/package.json (3)
53-53: tsdown bump mirrors other packagesConsistent with the monorepo; see earlier script to verify uniformity.
40-40: All effect dependencies aligned to 3.17.7Ran the audit across every
package.json—no packages are pinningeffectto a non-3.17.7 version. You’re clear to merge.
44-44: Approved: @effect/vitest 0.25.1 compatibility verifiedQuick consistency check across the repo shows:
- packages/shared & packages/uploadthing depend on
@effect/[email protected]- All packages (nuxt, react, shared, uploadthing, tooling/vitest-config) pin
[email protected]No mismatches found—ready to merge.
packages/uploadthing/package.json (3)
164-164: @effect/vitest 0.25.1 aligns with vitest 3.2.4No issues anticipated; ensure test suite remains green post-bump.
183-183: tsdown 0.14.1 bump consistent; confirm build pipelineGiven this package’s broader output surface (client/server/next/etc.), ensure CI builds for all targets succeed with tsdown 0.14.x.
You can reuse the tsdown verification script from the Vue package comment; additionally, confirm CI ran the build matrix for this package.
157-162: Upgrade to @effect/platform 0.90.3 requires migration; effect 3.17.7 is low-risk– For @effect/platform (0.85.x → 0.90.3), there are several breaking-change migration points. Please review and update:
• HttpClient API refactor – replace allHttpClient.fetchcalls with the new Context.Tag–based client methods (client.get/post/execute), wrap response helpers inEffect.scoped, and switch provisioning toFetchHttpClient.layer.
• Flat HTTP module exports – update imports to pullHttpClient,HttpClientRequest,HttpClientResponse, etc., directly from@effect/platforminstead of aggregated or indirect paths.
• Re-export removals and package consolidation – ensure any formerly re-exported types (e.g.NodeRuntime) are now imported from their explicit packages (e.g.@effect/platform-node).
• Transferable schema encoding fix – audit anyTransferableschemas for changed type shapes and adjust your type usages accordingly.
• HttpApi surface changes – if you useHttpApi, migrate to the new chainable API and update middleware/success-schema calls per the 3.10 release notes.
• Plus non-breaking yet important fixes around URL objects and multipart/query-param handling—run your full test suite against real HTTP flows.– For effect (3.16.x → 3.17.7), there are only minor, non-breaking additions (notably exposing
RcMap.has). No core runtime or scheduler changes were introduced.Next steps:
- Search your codebase for
HttpClient.fetch, flat-import paths,Transferable, and anyHttpApiusage and apply the above migrations.- Run
tscand your tests—TypeScript errors will pinpoint renamed/removed APIs.- Verify real-world HTTP flows (body parsing, multivalue params) in your integration tests.
playground-v6/package.json (1)
14-14: effect bump to 3.17.7 in playground — OKNo concerns. Sanity-check that example pages compile with the new effect version.
examples/backend-adapters/server/package.json (1)
16-18: Backend adapters updated to latest @effect versions — manual smoke test recommendedWe’ve bumped
@effect/platformto 0.90.3 and@effect/platform-nodeto 0.96.0 (also applies at line 24). These align with core packages, but subtle API tweaks can slip through—please spin up each server variant and confirm nothing breaks:In
examples/backend-adapters/server/package.json, run:
- build:
npm run build→tsc- dev:cf:
npm run dev:cf→wrangler dev --port 3003- dev:elysia:
npm run dev:elysia→NODE_ENV=development bun run --hot src/elysia.ts- dev:express:
npm run dev:express→NODE_ENV=development tsx watch src/express.ts- dev:fastify:
npm run dev:fastify→NODE_ENV=development tsx watch src/fastify.ts- dev:hono:
npm run dev:hono→NODE_ENV=development tsx watch src/hono.ts- dev:h3:
npm run dev:h3→NODE_ENV=development listhen -w src/h3.ts- dev:effect:
npm run dev:effect→NODE_ENV=development PORT=3003 tsx watch src/effect-platform.tsOnce all variants start without errors, these changes are good to go.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/honest-days-love.md (1)
13-13: Polish the summary: remove “fix:” prefix and clarify capitalization.Changeset type is already encoded in the frontmatter; the body should be a concise, sentence-cased description. Recommend:
-fix: cjs interop issue +Fix CommonJS interop issue.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/honest-days-love.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/honest-days-love.md
[grammar] ~13-~13: There might be a mistake here.
Context: ...elte": patch --- fix: cjs interop issue
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: bundle-analyze-result
- GitHub Check: e2e-node (backend-adapters)
- GitHub Check: build
🔇 Additional comments (2)
.changeset/honest-days-love.md (2)
1-11: Frontmatter looks valid for a multi-package patch bump.The changeset header correctly targets the intended packages with patch releases. No issues spotted.
2-10: Confirm scope: are all listed framework packages affected by the CJS interop fix?If the interop issue didn’t impact every framework wrapper, consider narrowing the list to avoid unnecessary patch releases. Otherwise, keep as-is.
Summary by CodeRabbit
Chores
Changelog