Skip to content

[java] LawOfDemeter: False positive with Thread and ThreadLocalRandom #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linusjf opened this issue Dec 21, 2019 · 1 comment · Fixed by #3510
Closed

[java] LawOfDemeter: False positive with Thread and ThreadLocalRandom #2180

linusjf opened this issue Dec 21, 2019 · 1 comment · Fixed by #3510
Labels
a:false-positive PMD flags a piece of code that is not problematic
Milestone

Comments

@linusjf
Copy link

linusjf commented Dec 21, 2019

#2160 (comment)
Affects PMD Version:
6.20.0
Rule:
LawOfDemeter.
Description:
Thread.currentThread() and ThreadLocalRandom().current() calls must be exempted from the method chaining and local object creation flagging by this rule. These calls and objects returned are thread-specific and for all practical purposes are pseudo-static properties.
You can add ProcessHandle.current() as another API call to be treated similarly.

Code Sample demonstrating the issue:

package pmdtests;

import java.util.concurrent.ThreadLocalRandom;
import static java.lang.System.out;

public class TaskLocalRandom implements Runnable {

 
  @Override
  public void run() {
    StringBuilder sb = new StringBuilder(40);
    sb.append(Thread.currentThread().getName()).append(" with priority ")
      .append(Thread.currentThread().getPriority())
      .append(": %d %n");
    String str = sb.toString();
    for (int i = 0; i < 10; i++)
      out.printf(
          str, 
         ThreadLocalRandom.current().nextInt(10) );
  }
}

Running PMD through: [CLI | Ant | Maven | Gradle | Designer | Other]

@oowekyala oowekyala added a:false-positive PMD flags a piece of code that is not problematic needs-backport labels Feb 16, 2022
oowekyala added a commit to oowekyala/pmd that referenced this issue Feb 16, 2022
- Fixes pmd#2175
- Fixes pmd#2179
- Fixes pmd#1605: same fix as pmd#2179, since enum constants are static fields they are trusted.
- Fixes pmd#2180: the fix is not to special-case Thread, but to consider all static methods as trusted (consistent with the treatment of static fields in pmd#2179)
- Fixes pmd#2182: the fix is not to allow package-private access, but to allow a class to access fields of instances of the same class.
- Fixes pmd#1014
- Fixes pmd#2188
@adangel adangel added this to the 7.0.0 milestone Feb 25, 2022
@adangel adangel changed the title [Java] False positive: LawOfDemeter is not cognizant of Thread and ThreadLocalRandom's special status. [java] LawOfDemeter: False positive with Thread and ThreadLocalRandom Feb 25, 2022
@adangel adangel linked a pull request Feb 25, 2022 that will close this issue
5 tasks
@adangel adangel mentioned this issue Jan 23, 2023
55 tasks
@jsotuyod
Copy link
Member

This is fixed in PMD 7.0.0-rc1. It won't be backported to PMD 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:false-positive PMD flags a piece of code that is not problematic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants