[core] Fix XPath 2.0 Rule Chain Analyzer with Unions #2599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the XPath expression (//ForStatement | //WhileStatement | //DoStatement)//AssignmentOperator we threw away "AssignmentOperator" and started visiting at this node. But that's not possible, because that's not at the root of the expr.
Generated by 🚫 Danger |
|
Thanks! I found that recently in the update-saxon-version branch but didn't think to test it on master: oowekyala/pmd@87c0145887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
For the XPath expression
(//ForStatement | //WhileStatement | //DoStatement)//AssignmentOperatorwe threw away "AssignmentOperator" and started visiting at this node.
But that's not possible, because that's not at the root of the expr.
Related issues
That's the fix for the problem found in #2575
Ready?
./mvnw clean verifypasses (checked automatically by travis)