[javascript] NPE while creating rule violation when specifying explicit line numbers #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adangel
requested changes
Sep 24, 2021
There was a problem hiding this comment.
Thanks for the PR!
Please use the existing method setLines(int, int) instead of creating a new constructor.
You can call this method in EcmascriptRuleViolationFactory before returning the new rule violation.
|
@kevingnet I've fixed this myself, so that this fix can be part of the release today... |
Generated by 🚫 Danger |
adangel
added a commit
that referenced
this pull request
Sep 25, 2021
adangel
added a commit
that referenced
this pull request
Sep 25, 2021
[javascript] NPE while creating rule violation when specifying explicit line numbers #3516
|
@all-contributors please add @kevingnet for code |
|
I've put up a pull request to add @kevingnet! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
AbstractEcmascriptRule has a function that takes begin and end lines as parameters. However when using, it produces a null pointer exception. This solution adds the call to the constructor for ParametricRuleViolation in which it was added support for those two line parameters. The new constructor calls the default constructor and then sets the line parameters.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)