Skip to content

Fix #5030: [java] SwitchDensity false positive with pattern matching #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Oct 4, 2024

Describe the PR

I only added the isPatternLabel() method as we don't need getPattern() or getGuard() yet.

The rule already supported switch expressions, btw.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.7.0 milestone Oct 4, 2024
@ghost
Copy link

ghost commented Oct 4, 2024

1 Message
📖 Compared to main:
This changeset changes 500 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel merged commit 156f293 into pmd:main Oct 24, 2024
3 checks passed
@adangel adangel deleted the issue-5030 branch October 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] SwitchDensity false positive with pattern matching
1 participant