Skip to content

Fix #5261: [java] Fix NPE with empty pattern list #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix #5261: [java] Fix NPE with empty pattern list #5264

merged 2 commits into from
Oct 11, 2024

Conversation

oowekyala
Copy link
Member

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jsotuyod jsotuyod added the in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception label Oct 7, 2024
@jsotuyod jsotuyod added this to the 7.7.0 milestone Oct 7, 2024
@jsotuyod
Copy link
Member

jsotuyod commented Oct 7, 2024

@oowekyala net.sourceforge.pmd.lang.java.rule.internal.DataflowPassTest.testSimple() is now failing as it was using this very same source file as input.

@oowekyala
Copy link
Member Author

Thank you for noticing!

@ghost
Copy link

ghost commented Oct 7, 2024

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

adangel
adangel approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request Oct 11, 2024
@adangel
[doc] Update release notes (#5261, #5264)
fbde9b9
adangel added a commit that referenced this pull request Oct 11, 2024
@adangel
[java] Fix NPE with empty pattern list (#5264)
6bd7a9d 
Merge pull request #5264 from oowekyala:issue5261-npe-record-empty-components
@adangel adangel merged commit b724b4d into pmd:main Oct 11, 2024
3 checks passed
@oowekyala oowekyala deleted the issue5261-npe-record-empty-components branch October 11, 2024 20:28
@adangel adangel changed the title [java] Fix NPE with empty pattern list Fix #5261: [java] Fix NPE with empty pattern list Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.

[java] Record patterns with empty deconstructor lists lead to NPE
3 participants
@oowekyala @jsotuyod @adangel