Skip to content

Fix #5667: [apex] ApexUnitTestShouldNotUseSeeAllDataTrue false negative when seeAllDate parameter is a string #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

Fix #5667: [apex] ApexUnitTestShouldNotUseSeeAllDataTrue false negative when seeAllDate parameter is a string #5684

merged 3 commits into from
Apr 22, 2025

Conversation

tprouvot
Copy link
Contributor

Describe the PR

  • Updated ApexUnitTestShouldNotUseSeeAllDataTrueRule.java to check for SEE_ALL_DATA parameter value being true.
  • Added a new test case in ApexUnitTestShouldNotUseSeeAllDataTrue.xml to validate the updated rule.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

tprouvot added 2 commits April 14, 2025 11:09
@tprouvot
- Updated ApexUnitTestShouldNotUseSeeAllDataTrueRule.java to check …
f1d403f 
…for `SEE_ALL_DATA` parameter value being `true`.

- Added a new test case in `ApexUnitTestShouldNotUseSeeAllDataTrue.xml` to validate the updated rule.
@tprouvot
Refactor test
3a7ee5d
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 34 errors and 8 configuration errors.

Regression Tester Report

@tprouvot
Copy link
Contributor Author

Hi @adangel,
Don't know if you had a chance to view this PR, feel free to reach me if anything is missing.
Have a good day

@adangel adangel self-requested a review April 18, 2025 08:43
@adangel adangel changed the title [apex] Fix #5667 ApexUnitTestShouldNotUseSeeAllDataTrue false negative when seeAllDate parameter is a string Fix #5667: [apex] ApexUnitTestShouldNotUseSeeAllDataTrue false negative when seeAllDate parameter is a string Apr 18, 2025
adangel
adangel approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@adangel adangel added this to the 7.13.0 milestone Apr 22, 2025
adangel added a commit that referenced this pull request Apr 22, 2025
@adangel
[doc] Update release notes (#5667, #5684)
2edadbe
@adangel adangel merged commit 01a9125 into pmd:main Apr 22, 2025
12 checks passed
adangel added a commit that referenced this pull request Apr 22, 2025
@adangel
Fix #5667: [apex] ApexUnitTestShouldNotUseSeeAllDataTrue false negati…
b1c0eac 
…ve when seeAllDate parameter is a string (#5684)

Merge pull request #5684 from tprouvot:fix/#5667-apex-seeAllDataEnclosedInQuotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.13.0
Development

Successfully merging this pull request may close these issues.

[apex] ApexUnitTestShouldNotUseSeeAllDataTrue false negative when seeAllData parameter is a string
2 participants
@tprouvot @adangel