Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/4959~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/4959
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Apr 18, 2025

  1. Configure interactive instance to restart timer 

    Use the published API from BackgroundPsql for automatically restarting
the timer rather than manually reaching into it to achieve the same
thing.

Reviewed-by: Heikki Linnakangas <[email protected]>
Reviewed-by: Andrew Dunstan <[email protected]>
Discussion: https://postgr.es/m/[email protected]
    @danielgustafsson
    danielgustafsson authored and Commitfest Bot committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    a5b6edf View commit details
    Browse the repository at this point in the history

  2. Report test failure rather than aborting in case of timeout 

    When an querying an interactive, or background, psql process the
call would die() in case of a timeout since it used the IPC::Run
timeout construct and not a timer. This aborts tests prematurely
which makes debugging harder, and stops getting results for the
remaining tests in the suite.  This converts to using a timer
object instead which will transfer control back to the caller
regardless, returning undef in case of a timeout along with
logging a test failure. Affected callsites are also updated to
reflect this.

Reviewed-by: Heikki Linnakangas <[email protected]>
Reviewed-by: Andrew Dunstan <[email protected]>
Discussion: https://postgr.es/m/[email protected]
    @danielgustafsson
    danielgustafsson authored and Commitfest Bot committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    f1ce8d6 View commit details
    Browse the repository at this point in the history

  3. [CF 4959] v4 - Fix BackgroundPsql to report error on query timeout ra… 

    …ther than calling die

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/4959

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Daniel Gustafsson
    Commitfest Bot committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    1ee4ba0 View commit details
    Browse the repository at this point in the history
Loading