Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5495~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5495
Choose a head ref
  • 5 commits
  • 20 files changed
  • 3 contributors

Commits on Apr 3, 2025

  1. Move common pg_dump code related to connections to a new file 

    ConnectDatabase is used by pg_dumpall, pg_restore and pg_dump so move
common code to new file.

new file name: connectdb.c

Author:    Mahendra Singh Thalor <[email protected]>
    @MahendraThalor
    MahendraThalor authored and Commitfest Bot committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    d939462 View commit details
    Browse the repository at this point in the history

  2. add new list type simple_oid_string_list to fe-utils/simple_list 

    This type contains both an oid and a string.

This will be used in forthcoming changes to pg_restore.

Author: Andrew Dunstan <[email protected]>
    @adunstan
    adunstan authored and Commitfest Bot committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    12a5a54 View commit details
    Browse the repository at this point in the history

  3. Non text modes for pg_dumpall, correspondingly change pg_restore 

    pg_dumpall acquires a new -F/--format option, with the same meanings as
pg_dump. The default is p, meaning plain text. For any other value, a
directory is created containing two files, globals.data and map.dat. The
first contains SQL for restoring the global data, and the second
contains a map from oids to database names. It will also contain a
subdirectory called databases, inside which it will create archives in
the specified format, named using the database oids.

In these casess the -f argument is required.

If pg_restore encounters a directory containing globals.dat, and no
toc.dat, it restores the global settings and then restores each
database.

pg_restore acquires two new options: -g/--globals-only which suppresses
restoration of any databases, and --exclude-database which inhibits
restoration of particualr database(s) in the same way the same option
works in pg_dumpall.

Author: Mahendra Singh Thalor <[email protected]>
Co-authored-by:  Andrew Dunstan <[email protected]>
Reviewed-by: jian he <[email protected]>
Reviewed-by: Srinath Reddy <[email protected]>
Reviewed-by: Álvaro Herrera <[email protected]>

Discussion: https://postgr.es/m/[email protected]
    @MahendraThalor
    MahendraThalor authored and Commitfest Bot committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    98b5038 View commit details
    Browse the repository at this point in the history

  4. Add more TAP tests for pg_dumpall 

    Author: Matheus Alcantara <[email protected]>
    @adunstan
    adunstan authored and Commitfest Bot committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    683defd View commit details
    Browse the repository at this point in the history

  5. [CF 5495] v20250403 - Non-text mode for pg_dumpall 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5495

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Mahendra Singh Thalor
    Commitfest Bot committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    575daae View commit details
    Browse the repository at this point in the history
Loading