Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5496~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5496
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 17, 2025

  1. Validate-max_slot_wal_keep_size-in-pg_createsubscriber 

    This patch introduces validation for the 'max_slot_wal_keep_size' GUC in the
'pg_createsubscriber' utility. The utility now checks that the publisher's
'max_slot_wal_keep_size' is set to '-1' during subscription creation.
This ensures proper functioning of logical replication slots.

The 'pg_createsubscriber' utility is updated to fetch and validate the
'max_slot_wal_keep_size' setting from the publisher. A warning is raised during
the '--dry-run' mode if the configuration is set to a non-default value.

This patch logs a warning if 'max_slot_wal_keep_size' is not set to '-1',
highlighting a potential risk of required WAL files being deleted on the
publisher, which could disrupt logical replication.
A test case has been added to validate correct warning reporting
when 'max_slot_wal_keep_size' is misconfigured.
    @KhannaShubham1197
    KhannaShubham1197 authored and Commitfest Bot committed Feb 17, 2025
    Configuration menu
    Copy the full SHA
    d973363 View commit details
    Browse the repository at this point in the history

  2. [CF 52/5496] v14 - Log a warning in pg_createsubscriber for max_slot_… 

    …wal_keep_size

This commit was automatically generated by a robot at cfbot.cputube.org.
It is based on patches submitted to the PostgreSQL mailing lists and
registered in the PostgreSQL Commitfest application.

This branch will be overwritten each time a new patch version is posted to
the email thread, and also periodically to check for bitrot caused by changes
on the master branch.

Commitfest entry: https://commitfest.postgresql.org/52/5496
Patch(es): https://www.postgresql.org/message-id/CAHv8RjKO1jabfcNVK5j_gd0Mrr07GQckPyhgRO59OvFwaYzo2Q@mail.gmail.com
Author(s):
    Commitfest Bot committed Feb 17, 2025
    Configuration menu
    Copy the full SHA
    dd77660 View commit details
    Browse the repository at this point in the history
Loading