Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5518~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5518
Choose a head ref
  • 4 commits
  • 15 files changed
  • 2 contributors

Commits on Jan 23, 2025

  1. [PATCH]: ./update-unused-lp-10-no-installcheck-v1.patch 

        Disable runningcheck for src/test/modules/injection_points/specs.

    Directory "injection_points" has specified NO_INSTALLCHECK since before
    commit c35f419 added the specs, but
    that commit neglected to disable the corresponding meson runningcheck.
    The alternative would be to enable "make installcheck" for ISOLATION,
    but the GNU make build system lacks a concept of setting NO_INSTALLCHECK
    for REGRESS without also setting it for ISOLATION.  Back-patch to v17,
    where that commit first appeared, to avoid surprises when back-patching
    additional specs.

    Reviewed by FIXME.

    Discussion: https://postgr.es/m/[email protected]
    Commitfest Bot committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    cc2d710 View commit details
    Browse the repository at this point in the history

  2. [PATCH]: ./update-unused-lp-40-xid2fxid-v1.patch 

        Merge copies of converting an XID to a FullTransactionId.

    Assume twophase.c is the performance-sensitive caller, and preserve its
    choice of unlikely() branch hint.  Add some retrospective rationale for
    that choice.  Back-patch to v17, for the next commit to use it.

    Reviewed (in earlier versions) by Michael Paquier.

    Discussion: https://postgr.es/m/[email protected]
    Discussion: https://postgr.es/m/[email protected]
    Commitfest Bot committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    cd78f34 View commit details
    Browse the repository at this point in the history

  3. [PATCH]: ./update-unused-lp-50-fix-v1.patch 

        At update of non-LP_NORMAL TID, fail instead of corrupting page header.

    The right mix of DDL and VACUUM could corrupt a page header such that
    PageIsVerified() durably fails, requiring a restore from backup.  One of
    the test permutations shows a variant not yet fixed.

    This makes !TransactionIdIsValid(TM_FailureData.xmax) possible with
    TM_Deleted.  Core and PGXN appear indifferent to that.

    Per bug #17821 from Alexander Lakhin.  Back-patch to v13 (all supported
    versions).  The test case is v17+, since it uses INJECTION_POINT.

    Reviewed by FIXME.

    Discussion: https://postgr.es/m/[email protected]
    Commitfest Bot committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    3951bb0 View commit details
    Browse the repository at this point in the history

  4. [CF 52/5518] At update of non-LP_NORMAL TID, fail instead of corrupti… 

    …ng page header

This commit was automatically generated by a robot at cfbot.cputube.org.
It is based on patches submitted to the PostgreSQL mailing lists and
registered in the PostgreSQL Commitfest application.

This branch will be overwritten each time a new patch version is posted to
the email thread, and also periodically to check for bitrot caused by changes
on the master branch.

Commitfest entry: https://commitfest.postgresql.org/52/5518
Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Noah Misch
    Commitfest Bot committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    b943ebb View commit details
    Browse the repository at this point in the history
Loading