Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5535~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5535
Choose a head ref
  • 7 commits
  • 31 files changed
  • 2 contributors

Commits on Apr 24, 2025

  1. Break out xxx2yyy_opt_overflow APIs for more datetime conversions. 

    Previous commits invented timestamp2timestamptz_opt_overflow,
date2timestamp_opt_overflow, and date2timestamptz_opt_overflow
functions to perform non-error-throwing conversions between
datetime types.  This patch completes the set by adding
timestamp2date_opt_overflow, timestamptz2date_opt_overflow,
and timestamptz2timestamp_opt_overflow.

In addition, adjust timestamp2timestamptz_opt_overflow so that it
doesn't throw error if timestamp2tm fails, but treats that as an
overflow case.  The situation probably can't arise except with an
invalid timestamp value, and I can't think of a way that that would
happen except data corruption.  However, it's pretty silly to have a
function whose entire reason for existence is to not throw errors for
out-of-range inputs nonetheless throw an error for out-of-range input.

The new APIs are not used in this patch, but will be needed by
btree_gin.

Discussion: https://postgr.es/m/[email protected]
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    f398aa4 View commit details
    Browse the repository at this point in the history

  2. Preliminary refactoring. 

    This step doesn't change any behavior.  It cleans the code up
slightly and documents it better.  In particular, the test
being used by gin_btree_compare_prefix is better explained (IMO)
and there's now an Assert backing up the assumption it has to make.

Discussion: https://postgr.es/m/[email protected]
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    3e6b5b0 View commit details
    Browse the repository at this point in the history

  3. Add cross-type comparisons for integer types. 

    Extend the infrastructure in btree_gin.c to permit cross-type
operators, and add the code to support them for the int2, int4,
and int8 opclasses.  (To keep this patch digestible, I left
the other datatypes for later.)

Discussion: https://postgr.es/m/[email protected]
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    866843c View commit details
    Browse the repository at this point in the history

  4. Add cross-type comparisons for float types.

    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    0bac5ac View commit details
    Browse the repository at this point in the history

  5. Add cross-type comparisons for string types. 

    (Only these two cases appear in the catalogs.)
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    c8281be View commit details
    Browse the repository at this point in the history

  6. Add cross-type comparisons for datetime types. 

    Discussion: https://postgr.es/m/[email protected]
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    a8821e9 View commit details
    Browse the repository at this point in the history

  7. [CF 5535] v3 - Cross-type index comparison support in contrib/btree_gin 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5535

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Tom Lane
    Commitfest Bot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    22088dd View commit details
    Browse the repository at this point in the history
Loading