Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5666~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5666
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Apr 8, 2025

  1. Fix crashes in logical replication during unique constraint violation… 

    …s on leaf partitions.

This commit addresses a logical replication crash introduced after commit
9ff6867, which occurs when incoming INSERT or UPDATE operations violate unique
constraints on leaf partitions.

The issue arises because the unique key conflict detection depended on the last
ExecOpenIndices call to construct necessary index information, where the
speculative parameter was set to true. However, this index opening was
redundant because the indexes were already opened during target partition
identification via the parent table (e.g., through ExecFindPartition) and hence
was removed in 9ff6867. Unfortunately, ExecFindPartition opens indexes without
constructing index information required for conflict detection, leading to the
crash.

While one solution could be to adjust ExecFindPartition to build this necessary
index information by adding a function parameter, this commit opts for a more
efficient approach: delaying index information initialization until a potential
conflict is detected. This avoids unnecessary index information construction
when there is no conflict.
    Hou Zhijie authored and Commitfest Bot committed Apr 8, 2025
    Configuration menu
    Copy the full SHA
    16a0ff6 View commit details
    Browse the repository at this point in the history

  2. [CF 5666] v2 - Logical replication worker Segmentation fault 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5666

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/OS3PR01MB57185F018C8F64689B44672B94B52@OS3PR01MB5718.jpnprd01.prod.outlook.com
Author(s): Zhijie Hou
    Commitfest Bot committed Apr 8, 2025
    Configuration menu
    Copy the full SHA
    e60e681 View commit details
    Browse the repository at this point in the history
Loading