Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5687~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5687
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 8, 2025

  1. Fix the 006_transfer_modes.pl test. 

    This test was leaving files like delete_old_cluster.sh in the
source directory for VPATH and meson builds.  To fix, change the
directory to tmp_check before running the test, as was done in
commits 15b6d21, 8af917b, and c462b05.

Oversight in commit af0d490.

Reported-by: Andrew Dunstan <andrew@dunslane.net> (on Discord)
Discussion: ???
    @nathan-bossart
    nathan-bossart authored and Commitfest Bot committed Apr 8, 2025
    Copy the full SHA
    1d3682a View commit details

  2. [CF 5687] v1 - prevent 006_transfer_modes.pl from leaving files behind 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5687

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/Z_RHkG770w3SE0yU@nathan
Author(s): Nathan Bossart
    Commitfest Bot committed Apr 8, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    8aefa34 View commit details
Showing with 5 additions and 0 deletions.
  1. +5 −0 src/bin/pg_upgrade/t/006_transfer_modes.pl
5 changes: 5 additions & 0 deletions src/bin/pg_upgrade/t/006_transfer_modes.pl
View file
Original file line number Diff line number Diff line change
@@ -102,6 +102,11 @@ sub test_mode
$new->clean_node();
}

# In a VPATH build, we'll be started in the source directory, but we want
# to run pg_upgrade in the build directory so that any files generated finish
# in it, like delete_old_cluster.{sh,bat}.
chdir ${PostgreSQL::Test::Utils::tmp_check};

test_mode('--clone');
test_mode('--copy');
test_mode('--copy-file-range');