Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5734~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5734
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on May 3, 2025

  1. Fix bug that could block the startup of parallel apply workers. 

    If a logical replication worker fails to start and its parent crashes
while waiting, its worker slot can remain marked as "in use".
This can prevent new workers from starting, as the launcher may not
find a free slot or may incorrectly think the sync or parallel apply
worker limits have been reached.

To handle this, the launcher already performs garbage collection
when no free slot is found or when the sync worker limit is hit,
and then retries launching workers. However, it previously did not
trigger garbage collection when the parallel apply worker limit
was reached. As a result, stale slots could block new parallel apply
workers from starting, even though they could have been launched
after cleanup.

This commit fixes the issue by triggering garbage collection
when the parallel apply worker limit is reached as well. If stale slots
are cleared and the number of parallel apply workers drops below
the limit, new parallel apply worker can then be started successfully.
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed May 3, 2025
    Configuration menu
    Copy the full SHA
    2b70787 View commit details
    Browse the repository at this point in the history

  2. Optimize slot reuse after garbage collection in logicalrep_worker_lau… 

    …nch().

Previously, when logicalrep_worker_launch() ran garbage collection and
cleaned up at least one worker slot, it would rescan all worker slots to
find a free one. However, since it is guaranteed that at least one slot was
freed in this case, this additional scan was unnecessary.

This commit removes the redundant scan and makes logicalrep_worker_launch()
immediately reuse the freed slot.
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed May 3, 2025
    Configuration menu
    Copy the full SHA
    815bdde View commit details
    Browse the repository at this point in the history

  3. [CF 5734] v3 - Improve logicalrep_worker_launch() logic 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5734

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Fujii Masao
    Commitfest Bot committed May 3, 2025
    Configuration menu
    Copy the full SHA
    cf14d6a View commit details
    Browse the repository at this point in the history
Loading