Add logfire.work_dir resource attribute
#532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
630b057
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd5f4b9c.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-logfire-work-dir.logfire-docs.pages.dev |
|
Can we dogfood with the resource attribute first? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 10206 10214 +8
Branches 1395 1396 +1
=========================================
+ Hits 10206 10214 +8 ☔ View full report in Codecov by Sentry. |
alexmojaki
reviewed
Oct 24, 2024
logfire/_internal/config.py
Outdated
Comment on lines
214
to
216
| Example: | ||
| If the `code.filename` is `/path/to/project/src/logfire/main.py` and the `root_path` is `src/`, the URL | ||
| for the source code will be `src/path/to/project/src/logfire/main.py`. |
alexmojaki
reviewed
Oct 24, 2024
logfire/_internal/config.py
Outdated
| """The root path for the source code in the repository. | ||
|
|
||
| Example: | ||
| If the `code.filename` is `/path/to/project/src/logfire/main.py` and the `root_path` is `src/`, the URL | ||
| for the source code will be `src/path/to/project/src/logfire/main.py`. | ||
| """ | ||
|
|
||
| work_dir: str = field(default='.') |
There was a problem hiding this comment.
Do we need this setting at all? Isn't it just os.getcwd()?
There was a problem hiding this comment.
Oh, I see what you mean...
349d4b5 to
cf67272
Compare
CodeSource.work_dirlogfire.work_dir resource attribute
alexmojaki
reviewed
Oct 29, 2024
Co-authored-by: Alex Hall <[email protected]>
Kludex
commented
Oct 29, 2024
alexmojaki
reviewed
Oct 29, 2024
Co-authored-by: Alex Hall <[email protected]>
alexmojaki
reviewed
Oct 29, 2024
logfire/_internal/config.py
Outdated
| @@ -672,6 +679,7 @@ def _initialize(self) -> None: | |||
| if self.code_source: | |||
| otel_resource_attributes.update( | |||
| { | |||
| RESOURCE_ATTRIBUTES_CODE_WORK_DIR: os.getcwd(), | |||
| RESOURCE_ATTRIBUTES_CODE_ROOT_PATH: self.code_source.root_path, | |||
There was a problem hiding this comment.
Can you leave it out here if it's empty?
alexmojaki
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I add the "exclude" already here?