Skip to content

Remove pytest pin and update deps #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

alexmojaki
Copy link
Contributor

Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d33fc01
Status: ✅  Deploy successful!
Preview URL: https://d7284dbb.logfire-docs.pages.dev
Branch Preview URL: https://alex-update-pytest-inline-sn.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki enabled auto-merge (squash) December 4, 2024 20:26
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6c4363e) to head (d33fc01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #643   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines        10686     10681    -5     
  Branches      1467      1465    -2     
=========================================
- Hits         10686     10681    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki merged commit e793014 into main Dec 5, 2024
13 checks passed
@alexmojaki alexmojaki deleted the alex/update-pytest-inline-snapshot branch December 5, 2024 09:16
@alexmojaki
Copy link
Contributor Author

Oops, forgot this was auto-merging. Oh well.

Updating pytest somehow revealed a gap in coverage in the failure case. I know that the pytest update improved executing's abilities in the context of pytest, but I don't know exactly what happened here. In any case I realized that the code was still saying that executing didn't work inside functions decorated with @logfire.instrument which is no longer true since it no longer uses AST modification. So I updated that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant