Skip to content

Allow CPython test to handle TLS libraries lacking FFDHE ciphersuites #131050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillChilds-Klein opened this issue Mar 10, 2025 · 2 comments
Closed
Labels
tests Tests in the Lib/test dir topic-SSL type-feature A feature request or enhancement

Comments

@WillChilds-Klein
Copy link
Contributor

WillChilds-Klein commented Mar 10, 2025

Feature or enhancement

Proposal:

Some cryptography TLS libraries, such as AWS-LC and BoringSSL, lack support for "finite field" ephemeral Diffie-Hellman (FFDHE) TLS ciphersuites. This causes failure test_ssl.ThreadedTests.test_dh_params when CPython is build against such libraries, as that test case assumes ciphersuite support of FFDHE. This issue proposes modifying test_dh_params to skip itself if the underlying TLS library does not support FFDHE.

Has this already been discussed elsewhere?

I have already discussed this feature proposal on Discourse

Links to previous discussion of this feature:

This issue is very similar to a series of other test modifications discussed in

https://discuss.python.org/t/support-building-ssl-and-hashlib-modules-against-aws-lc/44505/13

Linked PRs

@ZeroIntensity
Copy link
Member

cc @picnixz as a cryptography expert.

@ZeroIntensity ZeroIntensity added topic-SSL tests Tests in the Lib/test dir labels Mar 11, 2025
picnixz added a commit that referenced this issue Mar 29, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 29, 2025
…iphersuites (pythonGH-131051)

(cherry picked from commit be2d218)

Co-authored-by: Will Childs-Klein <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 29, 2025
…iphersuites (pythonGH-131051)

(cherry picked from commit be2d218)

Co-authored-by: Will Childs-Klein <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this issue Mar 29, 2025
…ciphersuites (GH-131051) (#131875)

gh-131050: skip `test_dh_params` when TLS library lacks FFDHE ciphersuites (GH-131051)
(cherry picked from commit be2d218)

Co-authored-by: Will Childs-Klein <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this issue Mar 29, 2025
…ciphersuites (GH-131051) (#131874)

gh-131050: skip `test_dh_params` when TLS library lacks FFDHE ciphersuites (GH-131051)
(cherry picked from commit be2d218)

Co-authored-by: Will Childs-Klein <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz picnixz closed this as completed Mar 29, 2025
@picnixz
Copy link
Member

picnixz commented Mar 29, 2025

Thanks for the report & patch

seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir topic-SSL type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants