-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
document positional-only arguments for collections.deque #100444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ran into this accidentally while using pypy and then was surprised when I used cpython and it didn't work |
I believe there was a decision to NOT broadly apply this across the documentation. The notion was the |
Thanks for the suggestion, but let's wait until there is a collective decision to go forward with doing this to all the docs, not just |
then should these be removed? $ git grep -E '^\.\. (method|function):: .*/[,)]' -- Doc/ | head -5
Doc/library/_thread.rst:.. function:: interrupt_main(signum=signal.SIGINT, /)
Doc/library/binascii.rst:.. function:: a2b_base64(string, /, *, strict_mode=False)
Doc/library/curses.rst:.. function:: wrapper(func, /, *args, **kwargs)
Doc/library/dataclasses.rst:.. function:: replace(obj, /, **changes)
Doc/library/functions.rst:.. function:: eval(expression, /, globals=None, locals=None)
$ git grep -E '^\.\. (method|function):: .*/[,)]' -- Doc/ | wc -l
107 |
No, I wouldn't remove them. Occasionally, some are added at the discretion of the maintainer when they think it might be useful. Previously, I mentioned And while I didn't make any of the edits that you found, I'm not worried about them. The users of Side note. I recommend not going down the path of "give me an exact, clearly defined rule, then I will sweep through the docs and apply it everywhere without consideration to each individual case". It is a tempting path, but our world is more nuanced than that and not all the developers agree on all the little decisions. To start contributing, I recommend starting with filed bug reports so that changes are directed at solving known user issues. In the past, Guido has advocated "holistic refactoring" focusing on the zeitgeist and needs of a particular module and its user base rather than non-holistic mark-and-sweep PRs (put another way, don't start by running |
yeah I'm not exactly new here but appreciate the message nonetheless |
Yes, of course, I know who you are. Just wanted to give a more thoughtful answer to your question than just "no" ;-) |
No description provided.