bpo-32836: Remove temporary variable usage #5680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need any tests? |
|
Not sure what you would test. There were no test for the temp variable in a symbol table to begin with (so a separate issue could be that we need some list / set / dict comprehension symbol table tests?) |
|
I marked this for 3.7 backport to keep the 3.8 & 3.7 symtable code in sync, but I don't think it's worth worrying about for 3.6 (since we're incredibly unlikely to make any further compiler changes on that branch). |
|
GH-5913 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 26, 2018
When comprehensions switched to using a nested scope, the old code for generating a temporary name to hold the accumulation target became redundant, but was never actually removed. Patch by Nitish Chandra. (cherry picked from commit 3a087be) Co-authored-by: Nitish Chandra <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 10, 2018
When comprehensions switched to using a nested scope, the old code for generating a temporary name to hold the accumulation target became redundant, but was never actually removed. Patch by Nitish Chandra. (cherry picked from commit 3a087be) Co-authored-by: Nitish Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
symtable_new_tmpnamemethod and also now unusedste_tmpnamefromPySTEntryObject.https://bugs.python.org/issue32836