enable multi-transformer defination #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/966
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 11113ff with merge base 9dc9eff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…-transformer-models-in-codebase
Gasoonjia
commented
Jul 30, 2024
| @@ -12,19 +12,23 @@ | |||
| from typing import Any, Dict, Optional, Tuple, Union | |||
|
|
|||
| import torch | |||
| import torch.nn as nn | |||
| from torch.distributed.device_mesh import DeviceMesh | |||
There was a problem hiding this comment.
Some irrelevant updates come from lintrunner
…-transformer-models-in-codebase
…-transformer-models-in-codebase
…-transformer-models-in-codebase
…-transformer-models-in-codebase
Jack-Khuu
requested changes
Aug 27, 2024
export_util/export_et.py
Outdated
| @@ -0,0 +1,135 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
This file got merged into export itself, you'll want the changes over there
Jack-Khuu
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the definition of multi-transformer models, including updates to ModelArgs and the Model class in the builder. These changes will serve as the primary entry point for both torchchat-defined models and imported models from torchtune.