Skip to content

Conversation

chiroito
Copy link
Member

For beginners who unfamiliar with the development environment that quarkus is associated with, I have clearly stated imports and dependencies and added instructions on how to check the application.

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the main branch is Quarkus 3, make sure you import the jakarta packages, since the javax won't be available

@chiroito chiroito requested a review from gastaldi February 28, 2023 06:59
@gastaldi
Copy link
Contributor

Please squash all your commits before we trigger the CI again

@chiroito
Copy link
Member Author

chiroito commented Mar 1, 2023

I squashed all my commits.

@gastaldi
Could you review this again, please?

@chiroito
Copy link
Member Author

chiroito commented Mar 8, 2023

@gastaldi Could you review this again, please?

@gastaldi gastaldi merged commit df7ca37 into quarkusio:main Mar 8, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 8, 2023
@gastaldi
Copy link
Contributor

gastaldi commented Mar 8, 2023

Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants