OpenShift binary build fails when current namespace is different #31737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we select either `quarkus.kubernetes.namespace=XX` or `quarkus.openshift.namespace=XX`, the namespace `XX` should be used instead of the namespace that is configured by default (via `oc project YY` for example). Fix quarkusio#26180
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
iocanel
approved these changes
Mar 10, 2023
No, because the resources are already updated to set the namespace from the configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we select either
quarkus.kubernetes.namespace=XXorquarkus.openshift.namespace=XX, the namespaceXXshould be used instead of the namespace that is configured by default (viaoc project YYfor example).Fix #26180