Skip to content

Conversation

mskacelik
Copy link
Contributor

@mskacelik mskacelik commented Mar 13, 2023

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/graphql area/smallrye labels Mar 13, 2023
@mskacelik mskacelik changed the title Register missing dynamic GraphQL client's implementation classes for … Update SmallRye GraphQL to 2.1.2 Mar 13, 2023
Comment on lines +67 to +69
services.produce(ServiceProviderBuildItem.allProvidersFromClassPath("io.smallrye.graphql.client.core.Directive"));
services.produce(
ServiceProviderBuildItem.allProvidersFromClassPath("io.smallrye.graphql.client.core.DirectiveArgument"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmartisk @mskacelik I'm surprised we use the service loader for these low level classes? What exactly does it allow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet The io.smallrye.graphql.client.core package is scheduled to be moved into the MicroProfile API - so we supply our own "implementation" classes this way already. This is to allow users, for example, to build a Field using Field.field() where it will locate (and return) the implementation by itself via the ServiceLoader.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the clarification :).

@gsmet gsmet requested a review from jmartisk March 13, 2023 12:07
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2023

Failing Jobs - Building d85e455

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 342 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2136)

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"

@jmartisk jmartisk merged commit 83743e8 into quarkusio:main Mar 14, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 14, 2023
@mskacelik mskacelik deleted the smallrye-graphQL-2.1.2 branch March 14, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/graphql area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants