-
Notifications
You must be signed in to change notification settings - Fork 3k
Update SmallRye GraphQL to 2.1.2 #31809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the ServiceLoader. Added test
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
services.produce(ServiceProviderBuildItem.allProvidersFromClassPath("io.smallrye.graphql.client.core.Directive")); | ||
services.produce( | ||
ServiceProviderBuildItem.allProvidersFromClassPath("io.smallrye.graphql.client.core.DirectiveArgument")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmartisk @mskacelik I'm surprised we use the service loader for these low level classes? What exactly does it allow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet The io.smallrye.graphql.client.core
package is scheduled to be moved into the MicroProfile API - so we supply our own "implementation" classes this way already. This is to allow users, for example, to build a Field using Field.field()
where it will locate (and return) the implementation by itself via the ServiceLoader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the clarification :).
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building d85e455
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 342 more 📦 extensions/grpc/deployment✖
📦 extensions/vertx/deployment✖
✖
|
cc @jmartisk