Skip to content

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 14, 2023

No description provided.

@mkouba mkouba requested a review from Ladicek March 14, 2023 13:10
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/scheduler labels Mar 14, 2023
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight inconsistency between the Class<? extends Annotation> methods, where one calls beanDeployment directly and the other goes through the DotName variant, but that doesn't change the behavior in any way.

@mkouba mkouba force-pushed the arc-TransformedAnnotationsBuildItem-hasAnnotation branch from 3e4b5e4 to b15bb56 Compare March 14, 2023 13:20
@mkouba
Copy link
Contributor Author

mkouba commented Mar 14, 2023

Slight inconsistency between the Class<? extends Annotation> methods, where one calls beanDeployment directly and the other goes through the DotName variant, but that doesn't change the behavior in any way.

Ah, good catch! Fixed.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2023

Failing Jobs - Building b15bb56

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19
Native Tests - Data1 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 342 more

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"

@gsmet gsmet merged commit e514edc into quarkusio:main Mar 14, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants