Restore previous behavior of QuarkusTransaction#isActive() #47522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And mark is as deprecated. It was causing issues with IronJacamar so we have a proof that this change is disruptive. And transactions are critical enough that we don't want to take any risks. This is a follow-up of quarkusio#47212. And related to quarkiverse/quarkus-ironjacamar#174.
yrodiere
approved these changes
Apr 24, 2025
|
Should we add |
|
It might make sense, yes. @rsvoboda WDYT? |
Status for workflow
|
|
I opened these PRs: |
gastaldi
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Makes sense, haven't noticed that it broke Artemis with IronJacamar. I'll change IronJacamar once the getStatus() lands in 3.20, as provided by @aloubyansky in #47528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And mark is as deprecated.
It was causing issues with IronJacamar so we have a proof that this change is disruptive. And transactions are critical enough that we don't want to take any risks.
This is a follow-up of #47212.
And related to
quarkiverse/quarkus-ironjacamar#174.