Reflection-free deserializers - Better handle basic types #47553
Conversation
4f79ea1 to
ab8d361
Compare
| static boolean isBoxedPrimitive(String typeName) { | ||
| return "java.lang.Character".equals(typeName) || "java.lang.Short".equals(typeName) | ||
| || "java.lang.Integer".equals(typeName) || "java.lang.Long".equals(typeName) | ||
| || "java.lang.Float".equals(typeName) || "java.lang.Double".equals(typeName) | ||
| || "java.lang.Boolean".equals(typeName); | ||
| } |
There was a problem hiding this comment.
@Ladicek I was wondering if we should have a util in Jandex for this. I couldn't find one but maybe there is one?
There was a problem hiding this comment.
We don't have one, but it makes sense. I'll add PrimitiveType.isBox(Type) in the next version.
There was a problem hiding this comment.
👍🏽
That could probably be used in a lot of places.
| static ResultHandle getDefaultValue(BytecodeCreator bytecodeCreator, Type type) { | ||
| if (type.kind() != Kind.PRIMITIVE) { | ||
| return bytecodeCreator.loadNull(); | ||
| } | ||
|
|
||
| return switch (type.name().toString()) { | ||
| case "byte" -> bytecodeCreator.load(DEFAULT_BYTE); | ||
| case "boolean" -> bytecodeCreator.load(DEFAULT_BOOLEAN); | ||
| case "char" -> bytecodeCreator.load(DEFAULT_CHAR); | ||
| case "double" -> bytecodeCreator.load(DEFAULT_DOUBLE); | ||
| case "float" -> bytecodeCreator.load(DEFAULT_FLOAT); | ||
| case "int" -> bytecodeCreator.load(DEFAULT_INT); | ||
| case "long" -> bytecodeCreator.load(DEFAULT_LONG); | ||
| case "short" -> bytecodeCreator.load(DEFAULT_SHORT); | ||
| default -> throw new IllegalStateException("Type " + type + " should be handled by the switch"); | ||
| }; | ||
| } |
There was a problem hiding this comment.
@Ladicek do you see a better way to handle that? I need to assign a value to the ResultHandle, including for primitive types and I ended up with this but I was wondering if there was a better way to handle that.
There was a problem hiding this comment.
I don't think we have a method to load a default value based on given type. What you have is close to the best. (I'd personally avoid the static fields and just pass (byte) 0, false, '\0', 0.0, 0.0F, 0, 0L, (short) 0, but there's almost zero difference.)
(I actually think we don't have that in Gizmo 2 either. I'll make sure we add it, because it makes sense.)
There was a problem hiding this comment.
@Ladicek yes, Gizmo 2 is exactly where I expected this to go. I thought it was useful input from real world usage.
|
/cc @mariofusco |
Status for workflow
|
Fixes #47478