Make protected constructors callable again for resteasy reactive #47563
Conversation
The resteasy reactive param converter, which gets automatically generated, calls the fromString/valueOf/constructor of the wrapper class directly. This fails if the paramconveter and the wrapper class is housed in different class loader. We can ensure that the TCCL is the same CL as the wrapper class, by not considering the wrapper an application class anymore if it is in an external jar.
Status for workflow
|
|
@Postremus I would like to clarify something about this PR, does it make sense to backport it to 3.20? Or should it be merged only in branches with the class loader changes from Holly? I backported it to 3.20 and tests pass but I'm not sure it's the right thing to do. |
Fixes quarkusio#47744 Related to quarkusio#47563 (cherry picked from commit 993aa24)
Fixes quarkusio#47744 Related to quarkusio#47563 (cherry picked from commit 993aa24)
|
@jmartisk I see this one in 3.20 AFAICS. I don't think we need to backport it again. Can you check? |
|
Right, the related product JIRA was in the wrong state hence I thought this still wasn't in, but this is already in 3.20.2... Thanks for spotting it. |
The resteasy reactive param converter, which gets automatically generated, calls the fromString/valueOf/constructor of the wrapper class directly. This fails if the paramconveter and the wrapper class is housed in different class loader. We can ensure that the TCCL is the same CL as the wrapper class, by not considering the wrapper an application class anymore if it is in an external jar.
related to #47471
This reverts #39691 (but also adds tests)
Follows up on #39823