-
Notifications
You must be signed in to change notification settings - Fork 188
tiny_tds v3 #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good, especially changing the return false thing... absurd. I'd also like to consider refactoring how escape is called, so that a live connection object isn't required (maybe a class method, or maybe decoupling init & connect). |
Hi @aharpervc, all the changes I would like to have for a version 3 are on main. Any objections to release this version somewhere this week? |
Go for it 👍 |
I have a couple of ideas for a potential v3 release of
tiny_tds
. However, I did not work that much on code so far and also not sure if this is the direction that the project wants to take, so consider this issue a proposal.Potential content of the release:
false
when something went wrong with the query, throw an exception.false
and v3 is the best time to do so.Again, these are just a couple of ideas. I also read through #511 which suggest a new implementation based on the .NET client, but I personally would not like installing a .NET runtime for my Ruby project.
What do you think @aharpervc?
The text was updated successfully, but these errors were encountered: