Use RubyVM::InstructionSequence for callable source #53055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures it works regardless of the parser, and does not require reparsing the original source.
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Feb 2, 2025
…d of RubyVM::AbstractSyntaxTree. Ruby 3.4 introduces new Ruby parser called Prism. `RubyVM::AbstractSyntaxTree.of` raises an error: RubyVM::AbstractSyntaxTree.of: cannot get AST for ISEQ compiled by prism Essentially, extracting source codes from the file does not require parsing. InstructionSequence is better to do it. ref: - https://bugs.ruby-lang.org/issues/20761 - rails/rails#53055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures it works regardless of the parser, and does not require reparsing the original source.
This is in response to a ping on #53054.
cc @byroot