fix various types in glossary #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are definitely more in these docs that don't match the code, but here are a few fixes: * `EnterHook` needs to use function intersection instead of an optional `callback` parameter * some props in `LocationDescriptorObject` are optional * `RedirectFunction` seems to take just a `LocationDescriptor` object as far as I can tell from the source code
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are definitely more in these docs that don't match the code, but here are a few fixes:
EnterHookneeds to use function intersection instead of an optionalcallbackparameterLocationDescriptorObjectare optionalRedirectFunctionseems to take just aLocationDescriptorobject as far as I can tell from the source code