CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+## [3.6.3] - 2022-10-11
+
+### Changed
+
+- [#167](https://github.com/ruby-syntax-tree/syntax_tree/pull/167) - Change the error encountered when an `else` node does not have an associated `end` token to be a parse error.
+
 ## [3.6.2] - 2022-10-04
 
 ### Changed
@@ -364,7 +370,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 - 🎉 Initial release! 🎉
 
-[unreleased]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.6.2...HEAD
+[unreleased]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.6.3...HEAD
+[3.6.3]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.6.2...v3.6.3
 [3.6.2]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.6.1...v3.6.2
 [3.6.1]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.6.0...v3.6.1
 [3.6.0]: https://github.com/ruby-syntax-tree/syntax_tree/compare/v3.5.0...v3.6.0

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    syntax_tree (3.6.2)
+    syntax_tree (3.6.3)
       prettier_print
 
 GEM

lib/syntax_tree/parser.rb

@@ -1327,6 +1327,11 @@ def on_else(statements)
           token.is_a?(Kw) && %w[end ensure].include?(token.value)
         end
 
+      if index.nil?
+        message = "Cannot find expected else ending"
+        raise ParseError.new(message, *find_token_error(keyword.location))
+      end
+
       node = tokens[index]
       ending = node.value == "end" ? tokens.delete_at(index) : node
 

lib/syntax_tree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SyntaxTree
-  VERSION = "3.6.2"
+  VERSION = "3.6.3"
 end

test/parser_test.rb

@@ -55,5 +55,15 @@ def test_errors_on_missing_token_without_location
     def test_handles_strings_with_non_terminated_embedded_expressions
       assert_raises(Parser::ParseError) { SyntaxTree.parse('"#{"') }
     end
+
+    def test_errors_on_else_missing_two_ends
+      assert_raises(Parser::ParseError) { SyntaxTree.parse(<<~RUBY) }
+        def foo
+          if something
+          else
+            call do
+        end
+      RUBY
+    end
   end
 end