Block arguments in `if` statements uses `{`, triggering Rubocop

[renchap]

Sample code after formatting using @prettier/plugin-ruby 3:

    if current_user&.admin? ||
         Rails.application.config.x.team_ips.any? { |i|
           i.include?(request.remote_ip)
         }
      Rack::MiniProfiler.authorize_request
    end

This is triggering Rubocop, even after including this gem's config:

app/controllers/application_controller.rb:62:51: C: [Correctable] Style/BlockDelimiters: Avoid using {...} for multi-line blocks.
         Rails.application.config.x.team_ips.any? { |i|

The original code (formatted by the Prettier plugin v2) cas using do … end, which did not trigger Rubocop.

I am not sure what is the correct fix here:

• Format the code to use do … end again (but this might not be safe if I understand Transform between braces & do/end when reflowing blocks? #120 correctly)
• Have the Rubocop config ignore this rule, as this gem will format it correctly

[kddnewton]

I'm pretty sure the fix here is to check for Binary nodes as well here: https://github.com/ruby-syntax-tree/syntax_tree/pull/121/files#diff-4a62a987e00853ea4da04a58594e31564bc9afc77a1cbdf95f95493784360659R1981. Want to take a crack at it?

[varg90]

For someone who faces this issue and don't want to use # stree-ignore in their code, as a workaround just put the block into a variable and check for if variable instead.
I'd actually say, that this would make your code cleaner.

[maxnotarangelo]

I'm also running into do...end to switching to braces on multiple lines when formatting. Adding it here in case it's useful.

Original:

def example
  return if array_of_things.any? do |complicated_thing|
    complicated_thing == another_thing
  end

  do_stuff
end

Formatted:

def example
  if array_of_things.any? { |complicated_thing|
       complicated_thing == another_thing
     }
    return
  end

  do_stuff
end

I'm not 100% sure the formatting isn't correct; something like the below formatting isn't great either.

def example
  if array_of_things.any? do |complicated_thing|
       complicated_thing == another_thing
     end
    return
  end

  do_stuff
end