Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few issues in the implementation related to aref_field, method_add_block and nested arguments.
ARefField
This boils down to a var_ref, so we were actually counting them twice. Also,
visit_aref_field
would be unnecessarily complicated if the collection was aCall
, which would need special treatment. Simply removing that visit makes it so that we only go through var_refs once and works when the collection is aCall
MethodAddBlock
These nodes have two parts: the call and the block. Only the block requires a fresh environment block, the call occurs in the same environment that the node is found. E.g.:
Nested arguments
We weren't handling the case where required positional arguments were "nested". E.g.:
I used recursion to fix this one because (to my surprise) it seems that Ruby allows you to have as many layers as desired. I assume most cases will only have one level, but better to model what Ruby allows you to do.