Skip to content

Adding Features #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

DRBragg
Copy link
Contributor

@DRBragg DRBragg commented Apr 21, 2022

This PR is the result of our pairing session. To recap, we added:

  • Allowing flow control operators to skip parens when they have single args (i.e. next(1) -> next 1)
  • Prevented conditionals with a single line conditional statement as it's only statement from creating a single line conditional (i.e. Dont turn:
if foo
  a ? b : c
end

into

a ? b : c if foo

Please let me know if I missed anything. Thanks again for hanging out. it was a blast pairing with you.

@kddnewton
Copy link
Member

Whoo hoo!

@kddnewton kddnewton merged commit 9794a06 into ruby-syntax-tree:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants