Skip to content

Conversation

@ksss
Copy link
Collaborator

@ksss ksss commented Dec 3, 2024

Ref: #1549

I have implemented 1 through 3 2 as proposed here.

@ksss
Copy link
Collaborator Author

ksss commented Dec 4, 2024

I have found that we should not issue warnings immediately because there is no method of recovery.
I will stop issuing warnings and scope up to stage 2.

@ksss ksss changed the title Deprecate stringio in core Milestone to graduate stringio from core. Dec 4, 2024
This is a milestone to allow stringio to be listed in manifest.yaml.
If this change permeates, it will be possible to specify stringio in manifest.yaml.
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.7 milestone Dec 4, 2024
@soutaro soutaro added this pull request to the merge queue Dec 4, 2024
Merged via the queue into ruby:master with commit e4b4d58 Dec 4, 2024
18 checks passed
@ksss ksss deleted the stringio branch December 4, 2024 11:01
@soutaro soutaro added the Released PRs already included in the released version label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released PRs already included in the released version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants