Skip to content

Change rendered_screen.lines to non-nil #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

Change rendered_screen.lines to non-nil #650

merged 1 commit into from
Mar 20, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Mar 19, 2024

It does not need to be nil. This will simplifies the code

ima1zumi
ima1zumi approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ima1zumi ima1zumi merged commit 9685db5 into ruby:master Mar 20, 2024
matzbot pushed a commit to ruby/ruby that referenced this pull request Mar 20, 2024
@tompng @matzbot
[ruby/reline] Change rendered_screen.lines to non-nil
aa2cdaa 
(ruby/reline#650)

ruby/reline@9685db55f1
@tompng tompng deleted the rendered_lines_nonnil branch March 20, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @ima1zumi