Cargo clippy crashes on veloren with nightly-2022-07-19

[xMAC94x]

Summary

git clone "https://gitlab.com/veloren/veloren.git"
git checkout ec8c06c9ac49d239fa14c77ebcf9139d6645ec0d
# note: you can also compile the whole repo and not only common/net, but that takes longer
cd common/net
cargo clippy

Version

rustc 1.64.0-nightly (f8588549c 2022-07-18)
binary: rustc
commit-hash: f8588549c3c3d45c32b404210cada01e2a45def3
commit-date: 2022-07-18
host: x86_64-unknown-linux-gnu
release: 1.64.0-nightly
LLVM version: 14.0.6


nightly-2022-07-19-x86_64-unknown-linux-gnu

Error output

Backtrace

cargo clippy                                             101 ↵  95688  19:28:11 
warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/calendar.rs:11:33
 |
11 | #[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
 |                                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = note: `#[warn(clippy::derive_partial_eq_without_eq)]` on by default
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/character.rs:13:24
 |
13 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/cmd.rs:42:17
 |
42 | #[derive(Debug, PartialEq, Serialize, Deserialize, Clone)]
 |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/cmd.rs:58:17
 |
58 | #[derive(Debug, PartialEq, Serialize, Deserialize, Clone)]
 |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: unnecessary closure used with `bool::then`
 --> common/src/cmd.rs:868:40
  |
868 |             .find_map(|(kwd, command)| (kwd == keyword).then(|| command))
  |                                        ^^^^^^^^^^^^^^^^^----------------
  |                                                         |
  |                                                         help: use `then_some(..)` instead: `then_some(command)`
  |
  = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/combat.rs:904:30
  |
904 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/ability.rs:330:54
  |
330 | #[derive(Copy, Clone, Serialize, Deserialize, Debug, PartialEq)]
  |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/agent.rs:25:30
 |
25 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/agent.rs:41:30
 |
41 | #[derive(Copy, Clone, Debug, PartialEq)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/anchor.rs:8:30
|
8 | #[derive(Copy, Clone, Debug, PartialEq)]
|                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/aura.rs:74:54
 |
74 | #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
 |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/beam.rs:38:24
 |
38 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/beam.rs:49:54
 |
49 | #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
 |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/arthropod.rs:13:24
 |
13 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = note: `#[warn(clippy::needless_borrow)]` on by default
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/arthropod.rs:19:26
 |
19 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/biped_large.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/biped_large.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/biped_small.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/biped_small.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/bird_large.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/bird_large.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/bird_medium.rs:18:24
 |
18 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/bird_medium.rs:24:26
 |
24 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/dragon.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/dragon.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/fish_medium.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/fish_medium.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/fish_small.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/fish_small.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/golem.rs:17:24
 |
17 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/golem.rs:23:26
 |
23 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/humanoid.rs:32:24
 |
32 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/humanoid.rs:38:26
 |
38 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
 --> common/src/comp/body/object.rs:107:10
  |
107 |         *(&ALL_OBJECTS).choose(&mut rng).unwrap()
  |          ^^^^^^^^^^^^^^ help: change this to: `ALL_OBJECTS`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_low.rs:18:24
 |
18 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_low.rs:24:26
 |
24 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_medium.rs:18:24
 |
18 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_medium.rs:24:26
 |
24 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_small.rs:18:24
 |
18 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/quadruped_small.rs:24:26
 |
24 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/ship.rs:45:61
 |
45 |     pub fn random_with(rng: &mut impl rand::Rng) -> Self { *(&ALL_BODIES).choose(rng).unwrap() }
 |                                                             ^^^^^^^^^^^^^ help: change this to: `ALL_BODIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/ship.rs:48:10
 |
48 |         *(&ALL_AIRSHIPS).choose(rng).unwrap()
 |          ^^^^^^^^^^^^^^^ help: change this to: `ALL_AIRSHIPS`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/ship.rs:51:66
 |
51 |     pub fn random_ship_with(rng: &mut impl rand::Rng) -> Self { *(&ALL_SHIPS).choose(rng).unwrap() }
 |                                                                  ^^^^^^^^^^^^ help: change this to: `ALL_SHIPS`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/theropod.rs:13:24
 |
13 |         let species = *(&ALL_SPECIES).choose(&mut rng).unwrap();
 |                        ^^^^^^^^^^^^^^ help: change this to: `ALL_SPECIES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression borrows a value the compiler would automatically borrow
--> common/src/comp/body/theropod.rs:19:26
 |
19 |         let body_type = *(&ALL_BODY_TYPES).choose(rng).unwrap();
 |                          ^^^^^^^^^^^^^^^^^ help: change this to: `ALL_BODY_TYPES`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/buff.rs:415:23
  |
415 | #[derive(Clone, Copy, PartialEq, Debug, Serialize, Deserialize)]
  |                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: this expression borrows a value the compiler would automatically borrow
 --> common/src/comp/buff.rs:498:32
  |
498 |             .unwrap_or_else(|| (&[]).iter())
  |                                ^^^^^ help: change this to: `[]`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/controller.rs:97:24
 |
97 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/controller.rs:118:24
  |
118 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/controller.rs:232:30
  |
232 | #[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: unnecessary closure used with `bool::then`
--> common/src/comp/energy.rs:70:9
 |
70 |         (maximum != self.maximum).then(|| maximum)
 |         ^^^^^^^^^^^^^^^^^^^^^^^^^^----------------
 |                                   |
 |                                   help: use `then_some(..)` instead: `then_some(maximum)`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/fluid_dynamics.rs:12:30
 |
12 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/group.rs:42:30
 |
42 | #[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref on an immutable reference
 --> common/src/comp/group.rs:508:24
  |
508 |         members(group, &*groups, entities, alignments, uids).for_each(|(e, role)| match role {
  |                        ^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `groups`
  |
  = note: `#[warn(clippy::borrow_deref_ref)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

warning: unnecessary closure used with `bool::then`
 --> common/src/comp/health.rs:110:9
  |
110 |         (maximum != self.maximum).then(|| maximum)
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^----------------
  |                                   |
  |                                   help: use `then_some(..)` instead: `then_some(maximum)`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

warning: deref which would be done by auto-deref
 --> common/src/comp/health.rs:177:17
  |
177 |                 (*entry).0 += u64::try_from(-delta).unwrap_or(0);
  |                 ^^^^^^^^ help: try this: `entry`
  |
  = note: `#[warn(clippy::explicit_auto_deref)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref
 --> common/src/comp/health.rs:178:17
  |
178 |                 (*entry).1 = change.time
  |                 ^^^^^^^^ help: try this: `entry`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/inputs.rs:8:33
|
8 | #[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
|                                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/inventory/item/armor.rs:38:30
 |
38 | #[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/inventory/item/modular.rs:242:24
  |
242 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/inventory/item/mod.rs:214:30
  |
214 | #[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref which would be done by auto-deref
 --> common/src/comp/inventory/item/mod.rs:563:65
  |
563 |                 if let Some(set) = ability_map.get_ability_set(&*set_key) {
  |                                                                 ^^^^^^^^ help: try this: `set_key`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/inventory/loadout_builder.rs:787:23
  |
787 | #[derive(Copy, Clone, PartialEq, Deserialize, Serialize, Debug, EnumIter)]
  |                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref which would be done by auto-deref
  --> common/src/comp/inventory/loadout_builder.rs:1070:59
   |
1070 |                 .map_or(true, |item| equip_slot.can_hold(&*item.kind()))
   |                                                           ^^^^^^^^^^^^ help: try this: `item.kind()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/inventory/slot.rs:9:17
|
9 | #[derive(Debug, PartialEq)]
|                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/inventory/slot.rs:14:23
 |
14 | #[derive(Clone, Copy, PartialEq, Debug, Serialize, Deserialize)]
 |                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref on an immutable reference
 --> common/src/comp/inventory/trade_pricing.rs:462:36
  |
462 |             .map_or(item_name, |i| &*i);
  |                                    ^^^ help: if you would like to reborrow, try removing `&*`: `i`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

warning: deref which would be done by auto-deref
 --> common/src/comp/inventory/mod.rs:563:67
  |
563 |             .and_then(|item| self.loadout.get_slot_to_equip_into(&*item.kind()))
  |                                                                   ^^^^^^^^^^^^ help: try this: `item.kind()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref
 --> common/src/comp/inventory/mod.rs:574:67
  |
574 |             .and_then(|item| self.loadout.get_slot_to_equip_into(&*item.kind()))
  |                                                                   ^^^^^^^^^^^^ help: try this: `item.kind()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/invite.rs:5:30
|
5 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
|                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/invite.rs:11:30
 |
11 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/misc.rs:7:30
|
7 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
|                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/phys.rs:165:39
  |
165 | #[derive(Copy, Clone, Default, Debug, PartialEq, Serialize, Deserialize)]
  |                                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/phys.rs:172:39
  |
172 | #[derive(Copy, Clone, Default, Debug, PartialEq, Serialize, Deserialize)]
  |                                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/phys.rs:222:39
  |
222 | #[derive(Copy, Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
  |                                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/shockwave.rs:39:24
 |
39 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/comp/shockwave.rs:48:54
 |
48 | #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
 |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/comp/skillset/mod.rs:570:17
  |
570 | #[derive(Debug, PartialEq, Clone, Copy, Deserialize, Serialize)]
  |                 ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/generation.rs:15:37
 |
15 | #[derive(Debug, Deserialize, Clone, PartialEq)]
 |                                     ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/generation.rs:22:37
 |
22 | #[derive(Debug, Deserialize, Clone, PartialEq)]
 |                                     ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/lottery.rs:79:24
 |
79 | #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/npc.rs:10:23
 |
10 | #[derive(Clone, Copy, PartialEq)]
 |                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref on an immutable reference
 --> common/src/recipe.rs:204:58
  |
204 |                 .filter(|item| item.matches_recipe_input(&*input, amount))
  |                                                          ^^^^^^^ help: if you would like to reborrow, try removing `&*`: `input`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/skillset_builder.rs:12:23
 |
12 | #[derive(Copy, Clone, PartialEq, Serialize, Deserialize, Debug)]
 |                       ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/states/charged_melee.rs:184:54
  |
184 | #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
  |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/states/equipping.rs:13:30
 |
13 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/states/spin_melee.rs:178:30
  |
178 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/states/spin_melee.rs:186:54
  |
186 | #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
  |                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/states/sprite_interact.rs:131:30
  |
131 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
 --> common/src/states/use_item.rs:166:30
  |
166 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
  |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
  --> common/src/states/utils.rs:1194:30
   |
1194 | #[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
   |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
  --> common/src/states/utils.rs:1248:30
   |
1248 | #[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
   |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/states/wielding.rs:15:30
 |
15 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/terrain/site.rs:3:54
|
3 | #[derive(Debug, Copy, Clone, Serialize, Deserialize, PartialEq)]
|                                                      ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/terrain/structure.rs:15:27
 |
15 |     #[derive(Copy, Clone, PartialEq, Debug, Deserialize)]
 |                           ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/trade.rs:15:30
 |
15 | #[derive(Copy, Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/src/trade.rs:44:24
 |
44 | #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref which would be done by auto-deref
 --> common/src/trade.rs:242:60
  |
242 |                 trade.process_trade_action(party, action, &*inventories);
  |                                                            ^^^^^^^^^^^^ help: try this: `inventories`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: `veloren-common` (lib) generated 98 warnings
  Checking veloren-common-net v0.10.0 (/mnt/games/veloren/common/net)
warning: you are deriving `PartialEq` and can implement `Eq`
--> common/net/src/msg/client.rs:30:30
 |
30 | #[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize)]
 |                              ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = note: `#[warn(clippy::derive_partial_eq_without_eq)]` on by default
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: you are deriving `PartialEq` and can implement `Eq`
--> common/net/src/msg/client.rs:41:24
 |
41 | #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
 |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

warning: deref which would be done by auto-deref
--> common/net/src/msg/compression.rs:39:32
 |
39 |             encoder.write_all(&*uncompressed).expect(EXPECT_MSG);
 |                                ^^^^^^^^^^^^^ help: try this: `uncompressed`
 |
 = note: `#[warn(clippy::explicit_auto_deref)]` on by default
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref
--> common/net/src/msg/compression.rs:63:35
 |
63 |             bincode::deserialize(&*uncompressed).ok()
 |                                   ^^^^^^^^^^^^^ help: try this: `uncompressed`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref
--> common/net/src/msg/compression.rs:65:35
 |
65 |             bincode::deserialize(&*self.data).ok()
 |                                   ^^^^^^^^^^ help: try this: `self.data`
 |
 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref on an immutable reference
 --> common/net/src/msg/compression.rs:240:29
  |
240 |             png.write_image(&*x.as_raw(), x.width(), x.height(), image::ColorType::L8)
  |                             ^^^^^^^^^^^^
  |
  = note: `#[warn(clippy::borrow_deref_ref)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
  |
240 |             png.write_image(x.as_raw(), x.width(), x.height(), image::ColorType::L8)
  |                             ~~~~~~~~~~
help: if you would like to deref, try using `&**`
  |
240 |             png.write_image(&**x.as_raw(), x.width(), x.height(), image::ColorType::L8)
  |                             ~~~~~~~~~~~~~

warning: deref on an immutable reference
 --> common/net/src/msg/compression.rs:256:17
  |
256 |                 &*ws.3.as_raw(),
  |                 ^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
  |
256 |                 ws.3.as_raw(),
  |                 ~~~~~~~~~~~~~
help: if you would like to deref, try using `&**`
  |
256 |                 &**ws.3.as_raw(),
  |                 ~~~~~~~~~~~~~~~~

error: internal compiler error: compiler/rustc_middle/src/ty/consts.rs:206:18: expected ConstKind::Value

thread 'rustc' panicked at 'Box<dyn Any>', /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/compiler/rustc_errors/src/lib.rs:1391:9
stack backtrace:
 0:     0x7f0f3536ced0 - std::backtrace_rs::backtrace::libunwind::trace::h6b3f9f41ee650c4f
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
 1:     0x7f0f3536ced0 - std::backtrace_rs::backtrace::trace_unsynchronized::he56cb04310aea81a
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
 2:     0x7f0f3536ced0 - std::sys_common::backtrace::_print_fmt::h6d4ec34d6cd34171
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/sys_common/backtrace.rs:66:5
 3:     0x7f0f3536ced0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h01911f0526d8b05c
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/sys_common/backtrace.rs:45:22
 4:     0x7f0f353c82ac - core::fmt::write::h49f323f7091ea1c8
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/core/src/fmt/mod.rs:1198:17
 5:     0x7f0f3535dd85 - std::io::Write::write_fmt::hbf1f476d48d43edd
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/io/mod.rs:1672:15
 6:     0x7f0f3536fba1 - std::sys_common::backtrace::_print::h2bbdb393c4180f57
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/sys_common/backtrace.rs:48:5
 7:     0x7f0f3536fba1 - std::sys_common::backtrace::print::h4200c2a0dbbbc055
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/sys_common/backtrace.rs:35:9
 8:     0x7f0f3536fba1 - std::panicking::default_hook::{{closure}}::h393b25bd4d38364f
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/panicking.rs:295:22
 9:     0x7f0f3536f873 - std::panicking::default_hook::h70f1f206e4c542c6
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/panicking.rs:314:9
10:     0x5601736ef2ed - clippy_driver[ac06e27041bb799c]::ICE_HOOK::{closure#0}::{closure#0}
11:     0x7f0f353703d6 - std::panicking::rust_panic_with_hook::hdfebab2861adaf27
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/panicking.rs:702:17
12:     0x7f0f38aa22a1 - std[778605c8b9d7d939]::panicking::begin_panic::<rustc_errors[5ec552083a70b038]::ExplicitBug>::{closure#0}
13:     0x7f0f38a9f4d6 - std[778605c8b9d7d939]::sys_common::backtrace::__rust_end_short_backtrace::<std[778605c8b9d7d939]::panicking::begin_panic<rustc_errors[5ec552083a70b038]::ExplicitBug>::{closure#0}, !>
14:     0x7f0f38ae57e6 - std[778605c8b9d7d939]::panicking::begin_panic::<rustc_errors[5ec552083a70b038]::ExplicitBug>
15:     0x7f0f38a9e0f6 - std[778605c8b9d7d939]::panic::panic_any::<rustc_errors[5ec552083a70b038]::ExplicitBug>
16:     0x7f0f38a9cf45 - <rustc_errors[5ec552083a70b038]::HandlerInner>::bug::<&alloc[110eb368cf5d93ca]::string::String>
17:     0x7f0f38a9cca0 - <rustc_errors[5ec552083a70b038]::Handler>::bug::<&alloc[110eb368cf5d93ca]::string::String>
18:     0x7f0f38b4b39d - rustc_middle[c6afec08b0d1be81]::ty::context::tls::with_context_opt::<rustc_middle[c6afec08b0d1be81]::ty::context::tls::with_opt<rustc_middle[c6afec08b0d1be81]::util::bug::opt_span_bug_fmt<rustc_span[7c9df871791ece55]::span_encoding::Span>::{closure#0}, ()>::{closure#0}, ()>
19:     0x7f0f38b50d06 - rustc_middle[c6afec08b0d1be81]::util::bug::opt_span_bug_fmt::<rustc_span[7c9df871791ece55]::span_encoding::Span>
20:     0x7f0f366bfdf3 - rustc_middle[c6afec08b0d1be81]::util::bug::bug_fmt
21:     0x7f0f38b8778f - <rustc_middle[c6afec08b0d1be81]::ty::consts::Const>::to_valtree
22:     0x560173b35469 - clippy_utils[28b1d72b212551fb]::consts::miri_to_const
23:     0x560173b336b3 - <clippy_utils[28b1d72b212551fb]::consts::ConstEvalLateContext>::expr
24:     0x560173b96067 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
25:     0x560173b969fa - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_exprs
26:     0x560173b964f0 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
27:     0x560173b969fa - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_exprs
28:     0x560173b964f0 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
29:     0x560173b961ae - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
30:     0x560173b961ae - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
31:     0x560173b96183 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
32:     0x560173b962b3 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
33:     0x560173b9656d - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
34:     0x560173b96319 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
35:     0x560173b9644a - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
36:     0x560173b95faa - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_block
37:     0x560173b963f3 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
38:     0x560173b9644a - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
39:     0x560173b962e7 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
40:     0x560173b96319 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
41:     0x560173b9644a - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
42:     0x560173b95faa - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_block
43:     0x560173b963f3 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
44:     0x560173b9644a - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
45:     0x560173b962e7 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
46:     0x560173b962b3 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
47:     0x560173b9644a - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
48:     0x560173b9718d - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_stmt
49:     0x560173b962b3 - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
50:     0x560173b9656d - <clippy_utils[28b1d72b212551fb]::hir_utils::SpanlessHash>::hash_expr
51:     0x560173b979c1 - clippy_utils[28b1d72b212551fb]::hir_utils::hash_expr
52:     0x560173a060d5 - <clippy_lints[4ef796904b1b0756]::copies::CopyAndPaste as rustc_lint[8984589cbb1ff449]::passes::LateLintPass>::check_expr
53:     0x7f0f38924c64 - <rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects as rustc_lint[8984589cbb1ff449]::passes::LateLintPass>::check_expr
54:     0x7f0f37c5b180 - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_expr
55:     0x7f0f37c5b2f9 - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_block
56:     0x7f0f37c5b18b - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_expr
57:     0x7f0f37c5b6ac - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_nested_body
58:     0x7f0f37c5b8f5 - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_fn
59:     0x7f0f37c6aa73 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_impl_item::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
60:     0x7f0f37c5c57f - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_nested_impl_item
61:     0x7f0f37c6b188 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_impl_item_ref::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
62:     0x7f0f37c6c190 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_item::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
63:     0x7f0f37c5c28e - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_nested_item
64:     0x7f0f37c6b787 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_mod::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
65:     0x7f0f37c5ba1c - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_mod
66:     0x7f0f37c5c28e - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_nested_item
67:     0x7f0f37c6b787 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_mod::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
68:     0x7f0f37c5ba1c - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_mod
69:     0x7f0f37c5c28e - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_nested_item
70:     0x7f0f37c6b787 - rustc_hir[a82dbec78fd9e7a2]::intravisit::walk_mod::<rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>>
71:     0x7f0f37c5ba1c - <rustc_lint[8984589cbb1ff449]::late::LateContextAndPass<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects> as rustc_hir[a82dbec78fd9e7a2]::intravisit::Visitor>::visit_mod
72:     0x7f0f37c5af63 - rustc_lint[8984589cbb1ff449]::late::late_lint_pass_crate::<rustc_lint[8984589cbb1ff449]::late::LateLintPassObjects>
73:     0x7f0f3780afa4 - rustc_lint[8984589cbb1ff449]::late::late_lint_crate::<rustc_lint[8984589cbb1ff449]::BuiltinCombinedLateLintPass>
74:     0x7f0f3780a539 - <rustc_session[b6be1dcf14d2202f]::session::Session>::time::<(), rustc_lint[8984589cbb1ff449]::late::check_crate<rustc_lint[8984589cbb1ff449]::BuiltinCombinedLateLintPass, rustc_interface[8ca32d3d634051a7]::passes::analysis::{closure#5}::{closure#1}::{closure#2}::{closure#0}::{closure#0}>::{closure#0}::{closure#0}>
75:     0x7f0f37584f20 - <rustc_session[b6be1dcf14d2202f]::session::Session>::time::<(), rustc_interface[8ca32d3d634051a7]::passes::analysis::{closure#5}::{closure#1}::{closure#2}::{closure#0}>
76:     0x7f0f37584b7f - <core[cd150e9e29982b29]::panic::unwind_safe::AssertUnwindSafe<rustc_interface[8ca32d3d634051a7]::passes::analysis::{closure#5}::{closure#1}> as core[cd150e9e29982b29]::ops::function::FnOnce<()>>::call_once
77:     0x7f0f3758450a - <rustc_session[b6be1dcf14d2202f]::session::Session>::time::<(), rustc_interface[8ca32d3d634051a7]::passes::analysis::{closure#5}>
78:     0x7f0f375820ec - rustc_interface[8ca32d3d634051a7]::passes::analysis
79:     0x7f0f3796222c - <rustc_query_system[2682b511cc84fabe]::dep_graph::graph::DepGraph<rustc_middle[c6afec08b0d1be81]::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle[c6afec08b0d1be81]::ty::context::TyCtxt, (), core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>
80:     0x7f0f379619eb - rustc_query_system[2682b511cc84fabe]::query::plumbing::try_execute_query::<rustc_query_impl[5e8382c68d202a33]::plumbing::QueryCtxt, rustc_query_system[2682b511cc84fabe]::query::caches::DefaultCache<(), core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>>
81:     0x7f0f3796153e - rustc_query_system[2682b511cc84fabe]::query::plumbing::get_query::<rustc_query_impl[5e8382c68d202a33]::queries::analysis, rustc_query_impl[5e8382c68d202a33]::plumbing::QueryCtxt>
82:     0x7f0f372b25ee - <rustc_interface[8ca32d3d634051a7]::passes::QueryContext>::enter::<rustc_driver[72308b4096139644]::run_compiler::{closure#1}::{closure#2}::{closure#3}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>
83:     0x7f0f372ae25e - <rustc_interface[8ca32d3d634051a7]::interface::Compiler>::enter::<rustc_driver[72308b4096139644]::run_compiler::{closure#1}::{closure#2}, core[cd150e9e29982b29]::result::Result<core[cd150e9e29982b29]::option::Option<rustc_interface[8ca32d3d634051a7]::queries::Linker>, rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>
84:     0x7f0f372a929f - rustc_span[7c9df871791ece55]::with_source_map::<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_interface[8ca32d3d634051a7]::interface::create_compiler_and_run<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_driver[72308b4096139644]::run_compiler::{closure#1}>::{closure#1}>
85:     0x7f0f372a8c90 - rustc_interface[8ca32d3d634051a7]::interface::create_compiler_and_run::<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_driver[72308b4096139644]::run_compiler::{closure#1}>
86:     0x7f0f372a7722 - <scoped_tls[3f6da10b6a2c80a0]::ScopedKey<rustc_span[7c9df871791ece55]::SessionGlobals>>::set::<rustc_interface[8ca32d3d634051a7]::interface::run_compiler<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_driver[72308b4096139644]::run_compiler::{closure#1}>::{closure#0}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>
87:     0x7f0f372a6bdf - std[778605c8b9d7d939]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[8ca32d3d634051a7]::util::run_in_thread_pool_with_globals<rustc_interface[8ca32d3d634051a7]::interface::run_compiler<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_driver[72308b4096139644]::run_compiler::{closure#1}>::{closure#0}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>::{closure#0}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>
88:     0x7f0f379e53e9 - <<std[778605c8b9d7d939]::thread::Builder>::spawn_unchecked_<rustc_interface[8ca32d3d634051a7]::util::run_in_thread_pool_with_globals<rustc_interface[8ca32d3d634051a7]::interface::run_compiler<core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>, rustc_driver[72308b4096139644]::run_compiler::{closure#1}>::{closure#0}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>::{closure#0}, core[cd150e9e29982b29]::result::Result<(), rustc_errors[5ec552083a70b038]::ErrorGuaranteed>>::{closure#1} as core[cd150e9e29982b29]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
89:     0x7f0f3537a193 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h1a098e41f44eb0a6
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/alloc/src/boxed.rs:1935:9
90:     0x7f0f3537a193 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hc5709f2569386b76
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/alloc/src/boxed.rs:1935:9
91:     0x7f0f3537a193 - std::sys::unix::thread::Thread::new::thread_start::h0444ab80c205eb75
                             at /rustc/f8588549c3c3d45c32b404210cada01e2a45def3/library/std/src/sys/unix/thread.rs:108:17
92:     0x7f0f34e8c54d - <unknown>
93:     0x7f0f34f11874 - clone
94:                0x0 - <unknown>

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.64 (f858854 2022-07-18)

query stack during panic:
#0 [analysis] running analysis passes on this crate
end of query stack
warning: `veloren-common-net` (lib) generated 7 warnings
error: could not compile `veloren-common-net`; 7 warnings emitted