consider autoderef through user-defined Deref in eager_or_lazy

[y21]

Fixes #10462

This PR handles autoderef in the eager_or_lazy util module and stops suggesting to change lazy to eager if autoderef in an expression goes through user defined Deref impls, e.g.

struct S;
impl Deref for S {
  type Target = ();
  fn deref(&self) -> &Self::Target { &() }
}

let _ = Some(()).as_ref().unwrap_or_else(|| &S); // autoderef `&S` -> `&()`

changelog: [unnecessary_lazy_evaluations]: don't suggest changing lazy evaluation to eager if autoderef goes through user-defined Deref

r? @xFrednet (because of the earlier review in #10864, might help for context here)

[xFrednet]

Thank you for the PR and review request :)

@blyxyas Do you first want to take a look at this PR? You also reviewed the previous one

[blyxyas]

Yep, will take it! 🐱

[blyxyas]

I don't think there's anything wrong with this. Let's hope it doesn't make a big toll on performance (By my benchmarks, it doesn't)! Thanks ❤️!

(Forgot to ping @xFrednet on the other reviews, sorry)

[xFrednet]

Looks good to me as well! Thank you for the update @y21!

---

Let's hope it doesn't make a big toll on performance (By my benchmarks, it doesn't)!

This change looks pretty simple, I would be surprised if it was even noticeable. Especially, since the condition is nested below other ones. But At the same time, it's good to check.

(Forgot to ping @xFrednet on the other reviews, sorry)

Usually, I still look at the ongoing conversation, in the other PR I just missed it. You're always welcome to ping me, though. Thank you for the review!

---

Now without further of due: Lord bors, would you mind merging this PR in the name of princess blyxyas and me?

[bors]

📌 Commit e70dd55 has been approved by blyxyas,xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit e70dd55 with merge 7c34ec8...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas,xFrednet
Pushing 7c34ec8 to master...

[blyxyas]

princess blyxyas

I'm genuine dying right now
Dies

[flip1995]

Now without further of due: Lord bors, would you mind merging this PR in the name of princess blyxyas and me?

How did you do it this time? How did you trigger bors, you magician? 😄

[xFrednet]

princess blyxyas

I'm genuine dying right now
Dies

Please don't I haven't learned any spells for resurrection. This kingdom still needs you

---

How did you do it this time?

Should a wizard reveal their power?

(It's the same magic trick I used a few months ago. GitHub still processes pings in markdown doc comments <!-- -->)

[flip1995]

Ah, I already forgot about this trick :D

[xFrednet]

Maybe I can use it again in a few months, to confuse you. Using it is always a lot of fun, and that's one of the reasons we're here, right? ^^