-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Description
Currently, both of the following return false:
(-0.0 as f64).asinh().is_sign_negative()
(-0.0 as f32).asinh().is_sign_negative()However, in other languages like C, asinh(-0.0) would always return -0.0. We might need another fast case for 0.0 and -0.0 here:
Lines 833 to 839 in f01b9f8
| pub fn asinh(self) -> f64 { | |
| if self == NEG_INFINITY { | |
| NEG_INFINITY | |
| } else { | |
| (self + ((self * self) + 1.0).sqrt()).ln() | |
| } | |
| } |
scottmcm
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.