-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Stabilize const unchecked conversion from u32 to char #126958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@rustbot ready (completed FCP in the tracking issue) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fcaa6fd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 704.234s -> 705.014s (0.11%) |
Closes #89259.
The functions in this PR were left out of the initial set of
feature(const_char_convert)
stabilizations in #102470, but have since been unblocked by #118979.If
unsafe { from_u32_unchecked(u) }
is called in const with a value for whichfrom_u32(u)
returns None, we get the following compile error.