Skip to content

Scala 2.13.16 (was .15) #22386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Scala 2.13.16 (was .15) #22386

merged 4 commits into from
Jan 18, 2025

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue SethTisue self-assigned this Jan 16, 2025
@SethTisue
Copy link
Member Author

@sjrd can I ask you to add a commit dealing with the AnyRefMap deprecation as you see fit?

@sjrd
Copy link
Member

sjrd commented Jan 16, 2025

I addressed the deprecation. Now it's blocked on not being able to resolve org.scalameta:mtags-shared_2.13.16:1.4.1.

@tgodzik
Copy link
Contributor

tgodzik commented Jan 16, 2025

I addressed the deprecation. Now it's blocked on not being able to resolve org.scalameta:mtags-shared_2.13.16:1.4.1.

We can update to 1.4.2, I released the support there.

@sjrd
Copy link
Member

sjrd commented Jan 16, 2025

Error:  Failed: Total 678, Failed 1, Errors 0, Passed 677, Ignored 7
Error:  Failed tests:
Error:  	dotty.tools.dotc.transform.PatmatExhaustivityTest

Someone wants to take over from here?

@SethTisue SethTisue added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jan 16, 2025
@SethTisue
Copy link
Member Author

SethTisue commented Jan 17, 2025

I fixed dotty.tools.dotc.transform.PatmatExhaustivityTest

but now:

Error:  (sbt-test / scripted) Failed tests:
Error:  	scala2-compat/erasure-scalajs

@sjrd I hoped that bumping the Scala.js version from 1.16.0 to 1.17.0 would make this failure go away, but when I did that, I got:

[error] -- [E107] Syntax Error: /Users/tisue/scala3/compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala:132:32 
[error] 132 |      case tpe @ jstpe.ClassType(cls) =>
[error]     |                 ^^^^^^^^^^^^^^^^^^^^
[error]     |Wrong number of argument patterns for dotty.tools.sjs.ir.Types.ClassType; expected: (dotty.tools.sjs.ir.Names.ClassName, Boolean)
[error]     |
[error]     | longer explanation available when compiling with `-explain`

bumping to 1.18.1 instead, same result.

can I kick this back to you again?

@sjrd
Copy link
Member

sjrd commented Jan 17, 2025

I published Scala.js 1.16.0 for Scala 2.13.16 to address that issue.

Upgrading the Scala.js version in this build can only be done for minor versions, and requires actual changes to keep up with breaking changes in the IR API.

@SethTisue SethTisue marked this pull request as ready for review January 18, 2025 01:55
@SethTisue SethTisue removed their assignment Jan 18, 2025
@WojciechMazur WojciechMazur merged commit 5bc04db into scala:main Jan 18, 2025
29 checks passed
@SethTisue SethTisue deleted the scala-2.13.16 branch January 18, 2025 13:34
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
@WojciechMazur WojciechMazur removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants