-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Nowarn public implicit val class params #22664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02cd651
to
0a80777
Compare
Explanation of protected member of given class is #8397 The warning considers any such member. |
So you're saying that you should only warn on private accessor, except that givens might be widened to protected so also warn about those. The other tweak, to only widen givens that have a human name, is therefore not strictly needed for warning purposes? if you're willing to warn about protected. |
@Gedochao I don't fell qualified to review this. I don't understand how/why there suddenly are |
Dowarn protected param accessor of given, which was probably widened.
0a80777
to
2cb2c92
Compare
@sjrd me neither. I removed that bit, which also didn't have a (new) test. This is just for the hapless warning. May I beg a review? github doesn't offer the |
@sjrd merci beaucoup. |
Similar to explicit param.
Fixes #22662